Commitdb94419

committed

pgbench: fix segfault with empty sql file

Commit1d0c3b3 introduced a bug that causes pgbench to crash if anempty script file is specified. Fix it by rejecting such files atstartup, which is the historical and intended behavior.Reported-By: Jeff JanesDiscussion:https://www.postgresql.org/message-id/CAMkU=1zxKUbLPOt9hQWFp14pTc=V0cGo2GQBbn2GsK2Pu+8ZfA@mail.gmail.com

1 parentd03130d commitdb94419Copy full SHA for db94419

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2686,7 +2686,8 @@ findBuiltin(const char name, char *desc)`
`2686`	`2686`	`staticvoid`
`2687`	`2687`	`addScript(constcharname,Command*commands)`
`2688`	`2688`	`{`
`2689`		`-if (commands==NULL)`
	`2689`	`+if (commands==NULL\|\|`
	`2690`	`+commands[0]==NULL)`
`2690`	`2691`	`{`
`2691`	`2692`	`fprintf(stderr,"empty command list for script \"%s\"\n",name);`
`2692`	`2693`	`exit(1);`

Comments

(0)