Commitd91da5e

committed

Remove useless use of bit-masking macros

In this case, the macros SET_8_BYTES(), GET_8_BYTES(), SET_4_BYTES(),GET_4_BYTES() are no-ops, so we can just remove them.The plan is to perhaps remove them from the source code altogether, sowe'll start here.Discussion:https://www.postgresql.org/message-id/5d51721a-69ef-2053-9172-599b539f0628@2ndquadrant.com

1 parent649aeb1 commitd91da5eCopy full SHA for d91da5e

File tree

-4

lines changed

-4

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -354,12 +354,12 @@ typedef struct NumericSumAccum`
`354`	`354`	`*/`
`355`	`355`	`#defineNUMERIC_ABBREV_BITS (SIZEOF_DATUM * BITS_PER_BYTE)`
`356`	`356`	`#ifSIZEOF_DATUM==8`
`357`		`-#defineNumericAbbrevGetDatum(X) ((Datum)SET_8_BYTES(X))`
`358`		`-#defineDatumGetNumericAbbrev(X) ((int64)GET_8_BYTES(X))`
	`357`	`+#defineNumericAbbrevGetDatum(X) ((Datum) (X))`
	`358`	`+#defineDatumGetNumericAbbrev(X) ((int64) (X))`
`359`	`359`	`#defineNUMERIC_ABBREV_NAN NumericAbbrevGetDatum(PG_INT64_MIN)`
`360`	`360`	`#else`
`361`		`-#defineNumericAbbrevGetDatum(X) ((Datum)SET_4_BYTES(X))`
`362`		`-#defineDatumGetNumericAbbrev(X) ((int32)GET_4_BYTES(X))`
	`361`	`+#defineNumericAbbrevGetDatum(X) ((Datum) (X))`
	`362`	`+#defineDatumGetNumericAbbrev(X) ((int32) (X))`
`363`	`363`	`#defineNUMERIC_ABBREV_NAN NumericAbbrevGetDatum(PG_INT32_MIN)`
`364`	`364`	`#endif`
`365`	`365`

Comments

(0)