Commitd76a149

committed

Clarify error message when attempting to create index on foreign table

Instead of just saying "is not a table", specifically state thatindexes aren't supported on *foreign* tables.

1 parentfb3ad78 commitd76a149Copy full SHA for d76a149

File tree

+16

-4

lines changed

+16

-4

lines changed

Lines changed: 16 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -183,10 +183,22 @@ DefineIndex(RangeVar *heapRelation,`
`183`	`183`	`/* Note: during bootstrap may see uncataloged relation */`
`184`	`184`	`if (rel->rd_rel->relkind!=RELKIND_RELATION&&`
`185`	`185`	`rel->rd_rel->relkind!=RELKIND_UNCATALOGED)`
`186`		`-ereport(ERROR,`
`187`		`-(errcode(ERRCODE_WRONG_OBJECT_TYPE),`
`188`		`-errmsg("\"%s\" is not a table",`
`189`		`-heapRelation->relname)));`
	`186`	`+{`
	`187`	`+if (rel->rd_rel->relkind==RELKIND_FOREIGN_TABLE)`
	`188`	`+/*`
	`189`	`+ * Custom error message for FOREIGN TABLE since the term is`
	`190`	`+ * close to a regular table and can confuse the user.`
	`191`	`+ */`
	`192`	`+ereport(ERROR,`
	`193`	`+(errcode(ERRCODE_WRONG_OBJECT_TYPE),`
	`194`	`+errmsg("cannot create index on foreign table \"%s\"",`
	`195`	`+heapRelation->relname)));`
	`196`	`+else`
	`197`	`+ereport(ERROR,`
	`198`	`+(errcode(ERRCODE_WRONG_OBJECT_TYPE),`
	`199`	`+errmsg("\"%s\" is not a table",`
	`200`	`+heapRelation->relname)));`
	`201`	`+}`
`190`	`202`
`191`	`203`	`/*`
`192`	`204`	`* Don't try to CREATE INDEX on temp tables of other backends.`

Comments

(0)