NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commitd65b5cc

committed

Correct obsolete nbtsort.c minimum key comment.

It is no longer possible under any circumstances for nbtree code toreconstruct a strict lower bound key (parent page's pivot tuple key) fora right sibling page by retrieving the first item in the right siblingpage.

1 parente5f9786 commitd65b5ccCopy full SHA for d65b5cc

File tree

1 file changed

-6

lines changed

src/backend/access/nbtree
- nbtsort.c

1 file changed

-6

lines changed

`‎src/backend/access/nbtree/nbtsort.c`

Lines changed: 4 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1007,9 +1007,8 @@ _bt_buildadd(BTWriteState wstate, BTPageState state, IndexTuple itup)`
`1007`	`1007`	`pfree(state->btps_minkey);`
`1008`	`1008`
`1009`	`1009`	`/*`
`1010`		`- * Save a copy of the minimum key for the new page. We have to copy`
`1011`		`- * it off the old page, not the new one, in case we are not at leaf`
`1012`		`- * level.`
	`1010`	`+ * Save a copy of the high key from the old page. It is also used as`
	`1011`	`+ * the minimum key for the new page.`
`1013`	`1012`	`*/`
`1014`	`1013`	`state->btps_minkey=CopyIndexTuple(oitup);`
`1015`	`1014`
`@@ -1045,9 +1044,8 @@ _bt_buildadd(BTWriteState wstate, BTPageState state, IndexTuple itup)`
`1045`	`1044`	`* If the new item is the first for its page, stash a copy for later. Note`
`1046`	`1045`	`* this will only happen for the first item on a level; on later pages,`
`1047`	`1046`	`* the first item for a page is copied from the prior page in the code`
`1048`		`- * above. Since the minimum key for an entire level is only used as a`
`1049`		`- * minus infinity downlink, and never as a high key, there is no need to`
`1050`		`- * truncate away suffix attributes at this point.`
	`1047`	`+ * above. The minimum key for an entire level is nothing more than a`
	`1048`	`+ * minus infinity (downlink only) pivot tuple placeholder.`
`1051`	`1049`	`*/`
`1052`	`1050`	`if (last_off==P_HIKEY)`
`1053`	`1051`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd65b5cc

File tree

1 file changed

1 file changed

`‎src/backend/access/nbtree/nbtsort.c`

0 commit comments