NotificationsYou must be signed in to change notification settings
Fork28
Star153

Commitd55e9ae

committed

Cleanup more code related to ws2_32.dll loading in src/port/getaddrinfo.c

e2e0219 has removed a code path for Windows 2000 that attempts to loadwship6.dll as fallback if ws2_32.dll is found but not getaddrinfo(),leaving behind a dangling pointer as the library is freed. However,there is no point in this check as ws2_32.dll exists since Windows XP,so just remove the duplicated check.Reported-by: Tom LaneDiscussion:https://postgr.es/m/9781.1582146114@sss.pgh.pa.us

1 parent6a8e560 commitd55e9aeCopy full SHA for d55e9ae

File tree

1 file changed

-10

lines changed

src/port
- getaddrinfo.c

1 file changed

-10

lines changed

`‎src/port/getaddrinfo.c‎`

Lines changed: 0 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -74,16 +74,6 @@ haveNativeWindowsIPv6routines(void)`
`74`	`74`	`*/`
`75`	`75`	`hLibrary=LoadLibraryA("ws2_32");`
`76`	`76`
`77`		`-if (hLibrary==NULL\|\|GetProcAddress(hLibrary,"getaddrinfo")==NULL)`
`78`		`-{`
`79`		`-/*`
`80`		`- * Well, ws2_32 doesn't exist, or more likely doesn't have`
`81`		`- * getaddrinfo.`
`82`		`- */`
`83`		`-if (hLibrary!=NULL)`
`84`		`-FreeLibrary(hLibrary);`
`85`		`-}`
`86`		`-`
`87`	`77`	`/* If hLibrary is null, we couldn't find a dll with functions */`
`88`	`78`	`if (hLibrary!=NULL)`
`89`	`79`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd55e9ae

File tree

1 file changed

1 file changed

`‎src/port/getaddrinfo.c‎`

0 commit comments