Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitd515365

Browse files
committed
Don't bother copying empty support arrays in a zero-column MergeJoin.
The case could not arise when this code was originally written, but it cannow (since we made zero-column MergeJoins work for the benefit of FULL JOINON TRUE). I don't think there is any actual bug here, but we might as welltreat it consistently with other uses of COPY_POINTER_FIELD(). Per commentfrom Ashutosh Bapat.
1 parente969f9a commitd515365

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

‎src/backend/nodes/copyfuncs.c

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -672,10 +672,13 @@ _copyMergeJoin(const MergeJoin *from)
672672
*/
673673
COPY_NODE_FIELD(mergeclauses);
674674
numCols=list_length(from->mergeclauses);
675-
COPY_POINTER_FIELD(mergeFamilies,numCols*sizeof(Oid));
676-
COPY_POINTER_FIELD(mergeCollations,numCols*sizeof(Oid));
677-
COPY_POINTER_FIELD(mergeStrategies,numCols*sizeof(int));
678-
COPY_POINTER_FIELD(mergeNullsFirst,numCols*sizeof(bool));
675+
if (numCols>0)
676+
{
677+
COPY_POINTER_FIELD(mergeFamilies,numCols*sizeof(Oid));
678+
COPY_POINTER_FIELD(mergeCollations,numCols*sizeof(Oid));
679+
COPY_POINTER_FIELD(mergeStrategies,numCols*sizeof(int));
680+
COPY_POINTER_FIELD(mergeNullsFirst,numCols*sizeof(bool));
681+
}
679682

680683
returnnewnode;
681684
}

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp