Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitd3f4e8a

Browse files
committed
Avoid formally-undefined use of memcpy() in hstoreUniquePairs().
hstoreUniquePairs() often called memcpy with equal source and destinationpointers. Although this is almost surely harmless in practice, it'sundefined according to the letter of the C standard. Some versions ofvalgrind will complain about it, and some versions of libc as well(cf. commitad520ec). Tweak the code to avoid doing that.Noted by Tomas Vondra. Back-patch to all supported versions becauseof the hazard of libc assertions.Discussion:https://postgr.es/m/bf84d940-90d4-de91-19dd-612e011007f4@fuzzy.cz
1 parent9b63c13 commitd3f4e8a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

‎contrib/hstore/hstore_io.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,8 @@ hstoreUniquePairs(Pairs *a, int32 l, int32 *buflen)
340340
{
341341
*buflen+=res->keylen+ ((res->isnull) ?0 :res->vallen);
342342
res++;
343-
memcpy(res,ptr,sizeof(Pairs));
343+
if (res!=ptr)
344+
memcpy(res,ptr,sizeof(Pairs));
344345
}
345346

346347
ptr++;

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp