Commitd2efb90

committed

Update comments about progress reporting by index_drop

Michaël Paquier complained that index_drop is requesting progressreporting for non-obvious reasons, so let's add a comment to explainwhy.Discussion:https://postgr.es/m/20191017010412.GH2602@paquier.xyz

1 parent3f60f69 commitd2efb90Copy full SHA for d2efb90

File tree

-1

lines changed

-1

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2142,6 +2142,10 @@ index_drop(Oid indexId, bool concurrent, bool concurrent_lock_mode)`
`2142`	`2142`	`* possible if one of the transactions in question is blocked trying`
`2143`	`2143`	`* to acquire an exclusive lock on our table. The lock code will`
`2144`	`2144`	`* detect deadlock and error out properly.`
	`2145`	`+ *`
	`2146`	`+ * Note: we report progress through WaitForLockers() unconditionally`
	`2147`	`+ * here, even though it will only be used when we're called by REINDEX`
	`2148`	`+ * CONCURRENTLY and not when called by DROP INDEX CONCURRENTLY.`
`2145`	`2149`	`*/`
`2146`	`2150`	`WaitForLockers(heaplocktag,AccessExclusiveLock, true);`
`2147`	`2151`
`@@ -2157,7 +2161,7 @@ index_drop(Oid indexId, bool concurrent, bool concurrent_lock_mode)`
`2157`	`2161`
`2158`	`2162`	`/*`
`2159`	`2163`	`* Wait till every transaction that saw the old index state has`
`2160`		`- * finished.`
	`2164`	`+ * finished. See above about progress reporting.`
`2161`	`2165`	`*/`
`2162`	`2166`	`WaitForLockers(heaplocktag,AccessExclusiveLock, true);`
`2163`	`2167`

Comments

(0)