NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commitd1f5a92

committed

Fix two small bugs in new gistget.c logic.

1. Complain, rather than silently doing nothing, if an "invalid" tupleis found on a leaf page. Per off-list discussion with Heikki.2. Fix oversight in code that removes a GISTSearchItem from the searchqueue: we have to reset lastHeap if this was the last heap item in theparent GISTSearchTreeItem. Otherwise subsequent additions will do thewrong thing. This was probably masked in early testing because in typicalcases the parent item would now be completely empty and would be deleted onnext call. You'd need a queued non-leaf page at exactly the same distanceas a heap tuple to expose the bug.

1 parent387e468 commitd1f5a92Copy full SHA for d1f5a92

File tree

1 file changed

-1

lines changed

src/backend/access/gist
- gistget.c

1 file changed

-1

lines changed

`‎src/backend/access/gist/gistget.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -70,9 +70,10 @@ gistindex_keytest(IndexScanDesc scan,`
`70`	`70`	`{`
`71`	`71`	`inti;`
`72`	`72`
	`73`	`+if (GistPageIsLeaf(page))/* shouldn't happen */`
	`74`	`+elog(ERROR,"invalid GIST tuple found on leaf page");`
`73`	`75`	`for (i=0;i<scan->numberOfOrderBys;i++)`
`74`	`76`	`so->distances[i]=-get_float8_infinity();`
`75`		`-recheck_p= true;/ probably unnecessary */`
`76`	`77`	`return true;`
`77`	`78`	`}`
`78`	`79`
`@@ -403,6 +404,8 @@ getNextGISTSearchItem(GISTScanOpaque so)`
`403`	`404`	`{`
`404`	`405`	`/* Delink item from chain */`
`405`	`406`	`so->curTreeItem->head=item->next;`
	`407`	`+if (item==so->curTreeItem->lastHeap)`
	`408`	`+so->curTreeItem->lastHeap=NULL;`
`406`	`409`	`/* Return item; caller is responsible to pfree it */`
`407`	`410`	`returnitem;`
`408`	`411`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd1f5a92

File tree

1 file changed

1 file changed

`‎src/backend/access/gist/gistget.c`

0 commit comments