Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitd133982

Browse files
committed
Force "restrict" not to be used when compiling with xlc.
Per buildfarm animal Hornet and followup manual testing by Noah Misch,it appears xlc miscompiles code using "restrict" in at least somecases. Allow disabling restrict usage with FORCE_DISABLE_RESTRICT=yesin template files, and do so for aix/xlc.Author: Andres Freund and Tom LaneDiscussion:https://postgr.es/m/1820.1507918762@sss.pgh.pa.us
1 parent6393613 commitd133982

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed

‎configure‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12466,6 +12466,10 @@ fi
1246612466
# spelling it understands, because it conflicts with
1246712467
# __declspec(restrict). Therefore we define pg_restrict to the
1246812468
# appropriate definition, which presumably won't conflict.
12469+
#
12470+
# Allow platforms with buggy compilers to force restrict to not be
12471+
# used by setting $FORCE_DISABLE_RESTRICT=yes in the relevant
12472+
# template.
1246912473
{$as_echo"$as_me:${as_lineno-$LINENO}: checking for C/C++ restrict keyword">&5
1247012474
$as_echo_n"checking for C/C++ restrict keyword...">&6; }
1247112475
if${ac_cv_c_restrict+:}false;then:
@@ -12512,7 +12516,7 @@ _ACEOF
1251212516
;;
1251312517
esac
1251412518

12515-
iftest"$ac_cv_c_restrict" ="no";then
12519+
iftest"$ac_cv_c_restrict" ="no"-o"x$FORCE_DISABLE_RESTRICT" ="xyes";then
1251612520
pg_restrict=""
1251712521
else
1251812522
pg_restrict="$ac_cv_c_restrict"

‎configure.in‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1329,8 +1329,12 @@ PGAC_TYPE_LOCALE_T
13291329
# spelling it understands, because it conflicts with
13301330
# __declspec(restrict). Therefore we define pg_restrict to the
13311331
# appropriate definition, which presumably won't conflict.
1332+
#
1333+
# Allow platforms with buggy compilers to force restrict to not be
1334+
# used by setting $FORCE_DISABLE_RESTRICT=yes in the relevant
1335+
# template.
13321336
AC_C_RESTRICT
1333-
if test "$ac_cv_c_restrict" = "no" ; then
1337+
if test "$ac_cv_c_restrict" = "no"-o "x$FORCE_DISABLE_RESTRICT" = "xyes"; then
13341338
pg_restrict=""
13351339
else
13361340
pg_restrict="$ac_cv_c_restrict"

‎src/template/aix‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ if test "$GCC" != yes ; then
1010
CFLAGS="-O2 -qmaxmem=16384 -qsrcmsg"
1111
;;
1212
esac
13+
14+
# Due to a compiler bug, see 20171013023536.GA492146@rfd.leadboat.com for details,
15+
# force restrict not to be used when compiling with xlc.
16+
FORCE_DISABLE_RESTRICT=yes
1317
fi
1418

1519
# Native memset() is faster, tested on:

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp