NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commitd0c0c89

committed

Fix unsafe extraction of the OID part of a relation filename.

Commit8694cc9 did this randomly differently from other callers ofparse_filename_for_nontemp_relation(). Perhaps unsurprisingly,the randomly different way is wrong; it fails to ensure theextracted string is null-terminated. Per buildfarm member skink.Discussion:https://postgr.es/m/14453.1522001792@sss.pgh.pa.us

1 parentbf4a867 commitd0c0c89Copy full SHA for d0c0c89

File tree

1 file changed

-1

lines changed

src/backend/replication
- basebackup.c

1 file changed

-1

lines changed

`‎src/backend/replication/basebackup.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1056,7 +1056,8 @@ sendDir(const char path, int basepathlen, bool sizeonly, List tablespaces,`
`1056`	`1056`	`* If any other type of fork, check if there is an init fork`
`1057`	`1057`	`* with the same OID. If so, the file can be excluded.`
`1058`	`1058`	`*/`
`1059`		`-strncpy(relOid,de->d_name,relOidChars);`
	`1059`	`+memcpy(relOid,de->d_name,relOidChars);`
	`1060`	`+relOid[relOidChars]='\0';`
`1060`	`1061`	`snprintf(initForkFile,sizeof(initForkFile),"%s/%s_init",`
`1061`	`1062`	`path,relOid);`
`1062`	`1063`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd0c0c89

File tree

1 file changed

1 file changed

`‎src/backend/replication/basebackup.c`

0 commit comments