@@ -3291,28 +3291,28 @@ execute_dml_stmt(ForeignScanState *node)
32913291 * Construct array of query parameter values in text format.
32923292 */
32933293if (numParams > 0 )
3294- {
3294+ // {
32953295process_query_params (econtext ,
32963296dmstate -> param_flinfo ,
32973297dmstate -> param_exprs ,
32983298values );
32993299
3300- /*
3301-
3302-
3303-
3304-
3305-
3306-
3307- if (!PQsendQueryParams (dmstate -> conn ,dmstate -> query ,numParams ,
3308- NULL ,values ,NULL ,NULL ,0 ))
3309- pgfdw_report_error (ERROR ,NULL ,dmstate -> conn , false,dmstate -> query );
3310- }
3311- else
3312- {
3313- if (!PQsendQuery (dmstate -> conn ,dmstate -> query ))
3314- pgfdw_report_error (ERROR ,NULL ,dmstate -> conn , false,dmstate -> query );
3315- }
3300+ /*
3301+ * Notice that we pass NULL for paramTypes, thus forcing the remote server
3302+ * to infer types for all parameters. Since we explicitly cast every
3303+ * parameter (see deparse.c), the "inference" is trivial and will produce
3304+ * the desired result. This allows us to avoid assuming that the remote
3305+ * server has the same OIDs we do for the parameters' types.
3306+ */
3307+ if (!PQsendQueryParams (dmstate -> conn ,dmstate -> query ,numParams ,
3308+ NULL ,values ,NULL ,NULL ,0 ))
3309+ pgfdw_report_error (ERROR ,NULL ,dmstate -> conn , false,dmstate -> query );
3310+ // }
3311+ // else
3312+ // {
3313+ // if (!PQsendQuery(dmstate->conn, dmstate->query))
3314+ // pgfdw_report_error(ERROR, NULL, dmstate->conn, false, dmstate->query);
3315+ // }
33163316
33173317/*
33183318 * Get the result, and check for success.