Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitc6f153d

Browse files
committed
Rethink how to test the hyperbolic functions.
The initial commit tried to test them on trivial cases such as 0,reasoning that we shouldn't hit any portability issues that way.The buildfarm immediately proved that hope ill-founded, and anywayit's not a great testing scheme because it doesn't prove that we'reeven calling the right library function for each SQL function.Instead, let's test them at inputs such as 1 (or something withinthe valid range, as needed), so that each function should producea different output.As committed, this is just about certain to show portabilityfailures, because it's very unlikely that every platform computesthese functions the same as mine down to the last bit. However,I want to put it through a buildfarm cycle this way, so thatwe can see how big the variations are. The plan is to add"set extra_float_digits = -1", or whatever we need in order tohide the variations; but first we need data.Discussion:https://postgr.es/m/E1h3nUY-0000sM-Vf@gemulon.postgresql.org
1 parentc6c9474 commitc6f153d

File tree

2 files changed

+33
-33
lines changed

2 files changed

+33
-33
lines changed

‎src/test/regress/expected/float8.out

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -454,44 +454,44 @@ SELECT '' AS five, * FROM FLOAT8_TBL;
454454
| -1.2345678901234e-200
455455
(5 rows)
456456

457+
RESET extra_float_digits;
457458
-- hyperbolic functions
458-
SELECT sinh(float8 '0');
459-
sinh
460-
------
461-
0
459+
SELECT sinh(float8 '1');
460+
sinh
461+
--------------------
462+
1.1752011936438014
462463
(1 row)
463464

464-
SELECT cosh(float8 '0');
465-
cosh
466-
------
467-
1
465+
SELECT cosh(float8 '1');
466+
cosh
467+
--------------------
468+
1.5430806348152437
468469
(1 row)
469470

470-
SELECT tanh(float8 '0');
471-
tanh
472-
------
473-
0
471+
SELECT tanh(float8 '1');
472+
tanh
473+
--------------------
474+
0.7615941559557649
474475
(1 row)
475476

476-
SELECT asinh(float8 '0');
477-
asinh
478-
-------
479-
0
477+
SELECT asinh(float8 '1');
478+
asinh
479+
-------------------
480+
0.881373587019543
480481
(1 row)
481482

482-
SELECT acosh(float8 '1');
483-
acosh
484-
-------
485-
0
483+
SELECT acosh(float8 '2');
484+
acosh
485+
--------------------
486+
1.3169578969248166
486487
(1 row)
487488

488-
SELECT atanh(float8 '0');
489-
atanh
490-
-------
491-
0
489+
SELECT atanh(float8 '0.5');
490+
atanh
491+
--------------------
492+
0.5493061443340548
492493
(1 row)
493494

494-
RESET extra_float_digits;
495495
-- test for over- and underflow
496496
INSERT INTO FLOAT8_TBL(f1) VALUES ('10e400');
497497
ERROR: "10e400" is out of range for type double precision

‎src/test/regress/sql/float8.sql

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -154,16 +154,16 @@ SELECT '' AS bad, f.f1 / '0.0' from FLOAT8_TBL f;
154154

155155
SELECT''AS five,*FROM FLOAT8_TBL;
156156

157-
-- hyperbolic functions
158-
SELECT sinh(float8'0');
159-
SELECT cosh(float8'0');
160-
SELECT tanh(float8'0');
161-
SELECT asinh(float8'0');
162-
SELECT acosh(float8'1');
163-
SELECT atanh(float8'0');
164-
165157
RESET extra_float_digits;
166158

159+
-- hyperbolic functions
160+
SELECT sinh(float8'1');
161+
SELECT cosh(float8'1');
162+
SELECT tanh(float8'1');
163+
SELECT asinh(float8'1');
164+
SELECT acosh(float8'2');
165+
SELECT atanh(float8'0.5');
166+
167167
-- test for over- and underflow
168168
INSERT INTO FLOAT8_TBL(f1)VALUES ('10e400');
169169

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp