Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitc160b89

Browse files
committed
Straighten out leakproofness markings on text comparison functions.
Since we introduced the idea of leakproof functions, texteq and textnewere marked leakproof but their sibling text comparison functions werenot. This inconsistency seemed justified because texteq/textne justrelied on memcmp() and so could easily be seen to be leakproof, whilethe other comparison functions are far more complex and indeed canthrow input-dependent errors.However, that argument crashed and burned with the addition ofnondeterministic collations, because now texteq/textne may invokethe exact same varstr_cmp() infrastructure as the rest. It makes nosense whatever to give them different leakproofness markings.After a certain amount of angst we've concluded that it's all rightto consider varstr_cmp() to be leakproof, mostly because the otherchoice would be disastrous for performance of many queries whereleakproofness matters. The input-dependent errors should only bereachable for corrupt input data, or so we hope anyway; certainly,if they are reachable in practice, we've got problems with requirementsas basic as maintaining a btree index on a text column.Hence, run around to all the SQL functions that derive from varstr_cmp()and mark them leakproof. This should result in a useful gain inflexibility/performance for queries in which non-leakproofness degradesthe efficiency of the query plan.Back-patch to v12 where nondeterministic collations were added.While this isn't an essential bug fix given the determinationthat varstr_cmp() is leakproof, we might as well apply it now thatwe've been forced into a post-beta4 catversion bump.Discussion:https://postgr.es/m/31481.1568303470@sss.pgh.pa.us
1 parent2810396 commitc160b89

File tree

5 files changed

+115
-81
lines changed

5 files changed

+115
-81
lines changed

‎src/backend/utils/adt/varlena.c‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1463,6 +1463,12 @@ check_collation_set(Oid collid)
14631463
*to allow null-termination for inputs to strcoll().
14641464
* Returns an integer less than, equal to, or greater than zero, indicating
14651465
* whether arg1 is less than, equal to, or greater than arg2.
1466+
*
1467+
* Note: many functions that depend on this are marked leakproof; therefore,
1468+
* avoid reporting the actual contents of the input when throwing errors.
1469+
* All errors herein should be things that can't happen except on corrupt
1470+
* data, anyway; otherwise we will have trouble with indexing strings that
1471+
* would cause them.
14661472
*/
14671473
int
14681474
varstr_cmp(constchar*arg1,intlen1,constchar*arg2,intlen2,Oidcollid)

‎src/include/catalog/catversion.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,6 @@
5353
*/
5454

5555
/*yyyymmddN */
56-
#defineCATALOG_VERSION_NO201909213
56+
#defineCATALOG_VERSION_NO201909214
5757

5858
#endif

‎src/include/catalog/pg_proc.dat‎

Lines changed: 66 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -681,44 +681,44 @@
681681
proname => 'nameeqtext', proleakproof => 't', prorettype => 'bool',
682682
proargtypes => 'name text', prosrc => 'nameeqtext' },
683683
{ oid => '241',
684-
proname => 'namelttext',prorettype => 'bool',proargtypes => 'name text',
685-
prosrc => 'namelttext' },
684+
proname => 'namelttext',proleakproof => 't',prorettype => 'bool',
685+
proargtypes => 'name text',prosrc => 'namelttext' },
686686
{ oid => '242',
687-
proname => 'nameletext',prorettype => 'bool',proargtypes => 'name text',
688-
prosrc => 'nameletext' },
687+
proname => 'nameletext',proleakproof => 't',prorettype => 'bool',
688+
proargtypes => 'name text',prosrc => 'nameletext' },
689689
{ oid => '243',
690-
proname => 'namegetext',prorettype => 'bool',proargtypes => 'name text',
691-
prosrc => 'namegetext' },
690+
proname => 'namegetext',proleakproof => 't',prorettype => 'bool',
691+
proargtypes => 'name text',prosrc => 'namegetext' },
692692
{ oid => '244',
693-
proname => 'namegttext',prorettype => 'bool',proargtypes => 'name text',
694-
prosrc => 'namegttext' },
693+
proname => 'namegttext',proleakproof => 't',prorettype => 'bool',
694+
proargtypes => 'name text',prosrc => 'namegttext' },
695695
{ oid => '245',
696696
proname => 'namenetext', proleakproof => 't', prorettype => 'bool',
697697
proargtypes => 'name text', prosrc => 'namenetext' },
698698
{ oid => '246', descr => 'less-equal-greater',
699-
proname => 'btnametextcmp',prorettype => 'int4',proargtypes => 'name text',
700-
prosrc => 'btnametextcmp' },
699+
proname => 'btnametextcmp',proleakproof => 't',prorettype => 'int4',
700+
proargtypes => 'name text',prosrc => 'btnametextcmp' },
701701
{ oid => '247',
702702
proname => 'texteqname', proleakproof => 't', prorettype => 'bool',
703703
proargtypes => 'text name', prosrc => 'texteqname' },
704704
{ oid => '248',
705-
proname => 'textltname',prorettype => 'bool',proargtypes => 'text name',
706-
prosrc => 'textltname' },
705+
proname => 'textltname',proleakproof => 't',prorettype => 'bool',
706+
proargtypes => 'text name',prosrc => 'textltname' },
707707
{ oid => '249',
708-
proname => 'textlename',prorettype => 'bool',proargtypes => 'text name',
709-
prosrc => 'textlename' },
708+
proname => 'textlename',proleakproof => 't',prorettype => 'bool',
709+
proargtypes => 'text name',prosrc => 'textlename' },
710710
{ oid => '250',
711-
proname => 'textgename',prorettype => 'bool',proargtypes => 'text name',
712-
prosrc => 'textgename' },
711+
proname => 'textgename',proleakproof => 't',prorettype => 'bool',
712+
proargtypes => 'text name',prosrc => 'textgename' },
713713
{ oid => '251',
714-
proname => 'textgtname',prorettype => 'bool',proargtypes => 'text name',
715-
prosrc => 'textgtname' },
714+
proname => 'textgtname',proleakproof => 't',prorettype => 'bool',
715+
proargtypes => 'text name',prosrc => 'textgtname' },
716716
{ oid => '252',
717717
proname => 'textnename', proleakproof => 't', prorettype => 'bool',
718718
proargtypes => 'text name', prosrc => 'textnename' },
719719
{ oid => '253', descr => 'less-equal-greater',
720-
proname => 'bttextnamecmp',prorettype => 'int4',proargtypes => 'text name',
721-
prosrc => 'bttextnamecmp' },
720+
proname => 'bttextnamecmp',proleakproof => 't',prorettype => 'int4',
721+
proargtypes => 'text name',prosrc => 'bttextnamecmp' },
722722

723723
{ oid => '266', descr => 'concatenate name and oid',
724724
proname => 'nameconcatoid', prorettype => 'name', proargtypes => 'name oid',
@@ -1002,14 +1002,14 @@
10021002
proname => 'btcharcmp', proleakproof => 't', prorettype => 'int4',
10031003
proargtypes => 'char char', prosrc => 'btcharcmp' },
10041004
{ oid => '359', descr => 'less-equal-greater',
1005-
proname => 'btnamecmp',prorettype => 'int4',proargtypes => 'name name',
1006-
prosrc => 'btnamecmp' },
1005+
proname => 'btnamecmp',proleakproof => 't',prorettype => 'int4',
1006+
proargtypes => 'name name',prosrc => 'btnamecmp' },
10071007
{ oid => '3135', descr => 'sort support',
10081008
proname => 'btnamesortsupport', prorettype => 'void',
10091009
proargtypes => 'internal', prosrc => 'btnamesortsupport' },
10101010
{ oid => '360', descr => 'less-equal-greater',
1011-
proname => 'bttextcmp',prorettype => 'int4',proargtypes => 'text text',
1012-
prosrc => 'bttextcmp' },
1011+
proname => 'bttextcmp',proleakproof => 't',prorettype => 'int4',
1012+
proargtypes => 'text text',prosrc => 'bttextcmp' },
10131013
{ oid => '3255', descr => 'sort support',
10141014
proname => 'bttextsortsupport', prorettype => 'void',
10151015
proargtypes => 'internal', prosrc => 'bttextsortsupport' },
@@ -1230,11 +1230,11 @@
12301230
proargmodes => '{v}', prosrc => 'pg_num_nonnulls' },
12311231

12321232
{ oid => '458', descr => 'larger of two',
1233-
proname => 'text_larger',prorettype => 'text',proargtypes => 'texttext',
1234-
prosrc => 'text_larger' },
1233+
proname => 'text_larger',proleakproof => 't',prorettype => 'text',
1234+
proargtypes => 'text text',prosrc => 'text_larger' },
12351235
{ oid => '459', descr => 'smaller of two',
1236-
proname => 'text_smaller',prorettype => 'text',proargtypes => 'texttext',
1237-
prosrc => 'text_smaller' },
1236+
proname => 'text_smaller',proleakproof => 't',prorettype => 'text',
1237+
proargtypes => 'text text',prosrc => 'text_smaller' },
12381238

12391239
{ oid => '460', descr => 'I/O',
12401240
proname => 'int8in', prorettype => 'int8', proargtypes => 'cstring',
@@ -1334,17 +1334,17 @@
13341334
prosrc => 'int28' },
13351335

13361336
{ oid => '655',
1337-
proname => 'namelt',prorettype => 'bool',proargtypes => 'name name',
1338-
prosrc => 'namelt' },
1337+
proname => 'namelt',proleakproof => 't',prorettype => 'bool',
1338+
proargtypes => 'name name',prosrc => 'namelt' },
13391339
{ oid => '656',
1340-
proname => 'namele',prorettype => 'bool',proargtypes => 'name name',
1341-
prosrc => 'namele' },
1340+
proname => 'namele',proleakproof => 't',prorettype => 'bool',
1341+
proargtypes => 'name name',prosrc => 'namele' },
13421342
{ oid => '657',
1343-
proname => 'namegt',prorettype => 'bool',proargtypes => 'name name',
1344-
prosrc => 'namegt' },
1343+
proname => 'namegt',proleakproof => 't',prorettype => 'bool',
1344+
proargtypes => 'name name',prosrc => 'namegt' },
13451345
{ oid => '658',
1346-
proname => 'namege',prorettype => 'bool',proargtypes => 'name name',
1347-
prosrc => 'namege' },
1346+
proname => 'namege',proleakproof => 't',prorettype => 'bool',
1347+
proargtypes => 'name name',prosrc => 'namege' },
13481348
{ oid => '659',
13491349
proname => 'namene', proleakproof => 't', prorettype => 'bool',
13501350
proargtypes => 'name name', prosrc => 'namene' },
@@ -1451,17 +1451,17 @@
14511451
proargtypes => 'circle point', prosrc => 'dist_cpoint' },
14521452

14531453
{ oid => '740',
1454-
proname => 'text_lt',prorettype => 'bool',proargtypes => 'text text',
1455-
prosrc => 'text_lt' },
1454+
proname => 'text_lt',proleakproof => 't',prorettype => 'bool',
1455+
proargtypes => 'text text',prosrc => 'text_lt' },
14561456
{ oid => '741',
1457-
proname => 'text_le',prorettype => 'bool',proargtypes => 'text text',
1458-
prosrc => 'text_le' },
1457+
proname => 'text_le',proleakproof => 't',prorettype => 'bool',
1458+
proargtypes => 'text text',prosrc => 'text_le' },
14591459
{ oid => '742',
1460-
proname => 'text_gt',prorettype => 'bool',proargtypes => 'text text',
1461-
prosrc => 'text_gt' },
1460+
proname => 'text_gt',proleakproof => 't',prorettype => 'bool',
1461+
proargtypes => 'text text',prosrc => 'text_gt' },
14621462
{ oid => '743',
1463-
proname => 'text_ge',prorettype => 'bool',proargtypes => 'text text',
1464-
prosrc => 'text_ge' },
1463+
proname => 'text_ge',proleakproof => 't',prorettype => 'bool',
1464+
proargtypes => 'text text',prosrc => 'text_ge' },
14651465

14661466
{ oid => '745', descr => 'current user name',
14671467
proname => 'current_user', provolatile => 's', prorettype => 'name',
@@ -2051,29 +2051,29 @@
20512051
proname => 'bpchareq', proleakproof => 't', prorettype => 'bool',
20522052
proargtypes => 'bpchar bpchar', prosrc => 'bpchareq' },
20532053
{ oid => '1049',
2054-
proname => 'bpcharlt',prorettype => 'bool',proargtypes => 'bpchar bpchar',
2055-
prosrc => 'bpcharlt' },
2054+
proname => 'bpcharlt',proleakproof => 't',prorettype => 'bool',
2055+
proargtypes => 'bpchar bpchar',prosrc => 'bpcharlt' },
20562056
{ oid => '1050',
2057-
proname => 'bpcharle',prorettype => 'bool',proargtypes => 'bpchar bpchar',
2058-
prosrc => 'bpcharle' },
2057+
proname => 'bpcharle',proleakproof => 't',prorettype => 'bool',
2058+
proargtypes => 'bpchar bpchar',prosrc => 'bpcharle' },
20592059
{ oid => '1051',
2060-
proname => 'bpchargt',prorettype => 'bool',proargtypes => 'bpchar bpchar',
2061-
prosrc => 'bpchargt' },
2060+
proname => 'bpchargt',proleakproof => 't',prorettype => 'bool',
2061+
proargtypes => 'bpchar bpchar',prosrc => 'bpchargt' },
20622062
{ oid => '1052',
2063-
proname => 'bpcharge',prorettype => 'bool',proargtypes => 'bpchar bpchar',
2064-
prosrc => 'bpcharge' },
2063+
proname => 'bpcharge',proleakproof => 't',prorettype => 'bool',
2064+
proargtypes => 'bpchar bpchar',prosrc => 'bpcharge' },
20652065
{ oid => '1053',
20662066
proname => 'bpcharne', proleakproof => 't', prorettype => 'bool',
20672067
proargtypes => 'bpchar bpchar', prosrc => 'bpcharne' },
20682068
{ oid => '1063', descr => 'larger of two',
2069-
proname => 'bpchar_larger', prorettype => 'bpchar',
2069+
proname => 'bpchar_larger',proleakproof => 't',prorettype => 'bpchar',
20702070
proargtypes => 'bpchar bpchar', prosrc => 'bpchar_larger' },
20712071
{ oid => '1064', descr => 'smaller of two',
2072-
proname => 'bpchar_smaller', prorettype => 'bpchar',
2072+
proname => 'bpchar_smaller',proleakproof => 't',prorettype => 'bpchar',
20732073
proargtypes => 'bpchar bpchar', prosrc => 'bpchar_smaller' },
20742074
{ oid => '1078', descr => 'less-equal-greater',
2075-
proname => 'bpcharcmp',prorettype => 'int4',proargtypes => 'bpchar bpchar',
2076-
prosrc => 'bpcharcmp' },
2075+
proname => 'bpcharcmp',proleakproof => 't',prorettype => 'int4',
2076+
proargtypes => 'bpchar bpchar',prosrc => 'bpcharcmp' },
20772077
{ oid => '3328', descr => 'sort support',
20782078
proname => 'bpchar_sortsupport', prorettype => 'void',
20792079
proargtypes => 'internal', prosrc => 'bpchar_sortsupport' },
@@ -6541,38 +6541,38 @@
65416541
proargtypes => 'float8 float8', prosrc => 'aggregate_dummy' },
65426542

65436543
{ oid => '2160',
6544-
proname => 'text_pattern_lt', prorettype => 'bool',
6544+
proname => 'text_pattern_lt',proleakproof => 't',prorettype => 'bool',
65456545
proargtypes => 'text text', prosrc => 'text_pattern_lt' },
65466546
{ oid => '2161',
6547-
proname => 'text_pattern_le', prorettype => 'bool',
6547+
proname => 'text_pattern_le',proleakproof => 't',prorettype => 'bool',
65486548
proargtypes => 'text text', prosrc => 'text_pattern_le' },
65496549
{ oid => '2163',
6550-
proname => 'text_pattern_ge', prorettype => 'bool',
6550+
proname => 'text_pattern_ge',proleakproof => 't',prorettype => 'bool',
65516551
proargtypes => 'text text', prosrc => 'text_pattern_ge' },
65526552
{ oid => '2164',
6553-
proname => 'text_pattern_gt', prorettype => 'bool',
6553+
proname => 'text_pattern_gt',proleakproof => 't',prorettype => 'bool',
65546554
proargtypes => 'text text', prosrc => 'text_pattern_gt' },
65556555
{ oid => '2166', descr => 'less-equal-greater',
6556-
proname => 'bttext_pattern_cmp', prorettype => 'int4',
6556+
proname => 'bttext_pattern_cmp',proleakproof => 't',prorettype => 'int4',
65576557
proargtypes => 'text text', prosrc => 'bttext_pattern_cmp' },
65586558
{ oid => '3332', descr => 'sort support',
65596559
proname => 'bttext_pattern_sortsupport', prorettype => 'void',
65606560
proargtypes => 'internal', prosrc => 'bttext_pattern_sortsupport' },
65616561

65626562
{ oid => '2174',
6563-
proname => 'bpchar_pattern_lt', prorettype => 'bool',
6563+
proname => 'bpchar_pattern_lt',proleakproof => 't',prorettype => 'bool',
65646564
proargtypes => 'bpchar bpchar', prosrc => 'bpchar_pattern_lt' },
65656565
{ oid => '2175',
6566-
proname => 'bpchar_pattern_le', prorettype => 'bool',
6566+
proname => 'bpchar_pattern_le',proleakproof => 't',prorettype => 'bool',
65676567
proargtypes => 'bpchar bpchar', prosrc => 'bpchar_pattern_le' },
65686568
{ oid => '2177',
6569-
proname => 'bpchar_pattern_ge', prorettype => 'bool',
6569+
proname => 'bpchar_pattern_ge',proleakproof => 't',prorettype => 'bool',
65706570
proargtypes => 'bpchar bpchar', prosrc => 'bpchar_pattern_ge' },
65716571
{ oid => '2178',
6572-
proname => 'bpchar_pattern_gt', prorettype => 'bool',
6572+
proname => 'bpchar_pattern_gt',proleakproof => 't',prorettype => 'bool',
65736573
proargtypes => 'bpchar bpchar', prosrc => 'bpchar_pattern_gt' },
65746574
{ oid => '2180', descr => 'less-equal-greater',
6575-
proname => 'btbpchar_pattern_cmp', prorettype => 'int4',
6575+
proname => 'btbpchar_pattern_cmp',proleakproof => 't',prorettype => 'int4',
65766576
proargtypes => 'bpchar bpchar', prosrc => 'btbpchar_pattern_cmp' },
65776577
{ oid => '3333', descr => 'sort support',
65786578
proname => 'btbpchar_pattern_sortsupport', prorettype => 'void',

‎src/test/regress/expected/opr_sanity.out‎

Lines changed: 42 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -526,9 +526,19 @@ int42ge(integer,smallint)
526526
oideq(oid,oid)
527527
oidne(oid,oid)
528528
nameeqtext(name,text)
529+
namelttext(name,text)
530+
nameletext(name,text)
531+
namegetext(name,text)
532+
namegttext(name,text)
529533
namenetext(name,text)
534+
btnametextcmp(name,text)
530535
texteqname(text,name)
536+
textltname(text,name)
537+
textlename(text,name)
538+
textgename(text,name)
539+
textgtname(text,name)
531540
textnename(text,name)
541+
bttextnamecmp(text,name)
532542
float4eq(real,real)
533543
float4ne(real,real)
534544
float4lt(real,real)
@@ -559,8 +569,12 @@ btfloat4cmp(real,real)
559569
btfloat8cmp(double precision,double precision)
560570
btoidcmp(oid,oid)
561571
btcharcmp("char","char")
572+
btnamecmp(name,name)
573+
bttextcmp(text,text)
562574
cash_cmp(money,money)
563575
btoidvectorcmp(oidvector,oidvector)
576+
text_larger(text,text)
577+
text_smaller(text,text)
564578
int8eq(bigint,bigint)
565579
int8ne(bigint,bigint)
566580
int8lt(bigint,bigint)
@@ -574,6 +588,10 @@ int84gt(bigint,integer)
574588
int84le(bigint,integer)
575589
int84ge(bigint,integer)
576590
oidvectorne(oidvector,oidvector)
591+
namelt(name,name)
592+
namele(name,name)
593+
namegt(name,name)
594+
namege(name,name)
577595
namene(name,name)
578596
oidvectorlt(oidvector,oidvector)
579597
oidvectorle(oidvector,oidvector)
@@ -582,6 +600,10 @@ oidvectorge(oidvector,oidvector)
582600
oidvectorgt(oidvector,oidvector)
583601
oidlt(oid,oid)
584602
oidle(oid,oid)
603+
text_lt(text,text)
604+
text_le(text,text)
605+
text_gt(text,text)
606+
text_ge(text,text)
585607
macaddr_eq(macaddr,macaddr)
586608
macaddr_lt(macaddr,macaddr)
587609
macaddr_le(macaddr,macaddr)
@@ -611,7 +633,14 @@ network_ne(inet,inet)
611633
network_cmp(inet,inet)
612634
lseg_eq(lseg,lseg)
613635
bpchareq(character,character)
636+
bpcharlt(character,character)
637+
bpcharle(character,character)
638+
bpchargt(character,character)
639+
bpcharge(character,character)
614640
bpcharne(character,character)
641+
bpchar_larger(character,character)
642+
bpchar_smaller(character,character)
643+
bpcharcmp(character,character)
615644
date_eq(date,date)
616645
date_lt(date,date)
617646
date_le(date,date)
@@ -707,6 +736,16 @@ timestamp_lt(timestamp without time zone,timestamp without time zone)
707736
timestamp_le(timestamp without time zone,timestamp without time zone)
708737
timestamp_ge(timestamp without time zone,timestamp without time zone)
709738
timestamp_gt(timestamp without time zone,timestamp without time zone)
739+
text_pattern_lt(text,text)
740+
text_pattern_le(text,text)
741+
text_pattern_ge(text,text)
742+
text_pattern_gt(text,text)
743+
bttext_pattern_cmp(text,text)
744+
bpchar_pattern_lt(character,character)
745+
bpchar_pattern_le(character,character)
746+
bpchar_pattern_ge(character,character)
747+
bpchar_pattern_gt(character,character)
748+
btbpchar_pattern_cmp(character,character)
710749
btint48cmp(integer,bigint)
711750
btint84cmp(bigint,integer)
712751
btint24cmp(smallint,integer)
@@ -1322,8 +1361,6 @@ WHERE o1.oprnegate = o2.oid AND p1.oid = o1.oprcode AND p2.oid = o2.oprcode AND
13221361

13231362
-- Btree comparison operators' functions should have the same volatility
13241363
-- and leakproofness markings as the associated comparison support function.
1325-
-- As of Postgres 12, the only exceptions are that textual equality functions
1326-
-- are marked leakproof but textual comparison/inequality functions are not.
13271364
SELECT pp.oid::regprocedure as proc, pp.provolatile as vp, pp.proleakproof as lp,
13281365
po.oid::regprocedure as opr, po.provolatile as vo, po.proleakproof as lo
13291366
FROM pg_proc pp, pg_proc po, pg_operator o, pg_amproc ap, pg_amop ao
@@ -1336,16 +1373,9 @@ WHERE pp.oid = ap.amproc AND po.oid = o.oprcode AND o.oid = ao.amopopr AND
13361373
(pp.provolatile != po.provolatile OR
13371374
pp.proleakproof != po.proleakproof)
13381375
ORDER BY 1;
1339-
proc | vp | lp | opr | vo | lo
1340-
-------------------------------------------+----+----+-------------------------------+----+----
1341-
btnametextcmp(name,text) | i | f | nameeqtext(name,text) | i | t
1342-
bttextnamecmp(text,name) | i | f | texteqname(text,name) | i | t
1343-
btnamecmp(name,name) | i | f | nameeq(name,name) | i | t
1344-
bttextcmp(text,text) | i | f | texteq(text,text) | i | t
1345-
bpcharcmp(character,character) | i | f | bpchareq(character,character) | i | t
1346-
bttext_pattern_cmp(text,text) | i | f | texteq(text,text) | i | t
1347-
btbpchar_pattern_cmp(character,character) | i | f | bpchareq(character,character) | i | t
1348-
(7 rows)
1376+
proc | vp | lp | opr | vo | lo
1377+
------+----+----+-----+----+----
1378+
(0 rows)
13491379

13501380
-- **************** pg_aggregate ****************
13511381
-- Look for illegal values in pg_aggregate fields.

‎src/test/regress/sql/opr_sanity.sql‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -806,8 +806,6 @@ WHERE o1.oprnegate = o2.oid AND p1.oid = o1.oprcode AND p2.oid = o2.oprcode AND
806806

807807
-- Btree comparison operators' functions should have the same volatility
808808
-- and leakproofness markings as the associated comparison support function.
809-
-- As of Postgres 12, the only exceptions are that textual equality functions
810-
-- are marked leakproof but textual comparison/inequality functions are not.
811809
SELECTpp.oid::regprocedureas proc,pp.provolatileas vp,pp.proleakproofas lp,
812810
po.oid::regprocedureas opr,po.provolatileas vo,po.proleakproofas lo
813811
FROM pg_proc pp, pg_proc po, pg_operator o, pg_amproc ap, pg_amop ao

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp