- Notifications
You must be signed in to change notification settings - Fork28
Commitbfb456c
committed
Improve error reporting for DROP FUNCTION/PROCEDURE/AGGREGATE/ROUTINE.
These commands allow the argument type list to be omitted if there isjust one object that matches by name. However, if that syntax wasused with DROP IF EXISTS and there was more than one match, you gota "function ... does not exist, skipping" notice message rather than atruthful complaint about the ambiguity. This was basically due topoor factorization and a rats-nest of logic, so refactor the relevantlookup code to make it cleaner.Note that this amounts to narrowing the scope of which sorts oferror conditions IF EXISTS will bypass. Per discussion, we onlyintend it to skip no-such-object cases, not multiple-possible-matchescases.Per bug #15572 from Ash Marath. Although this definitely seems likea bug, it's not clear that people would thank us for changing thebehavior in minor releases, so no back-patch.David Rowley, reviewed by Julien Rouhaud and Pavel StehuleDiscussion:https://postgr.es/m/15572-ed1b9ed09503de8a@postgresql.org1 parent0f086f8 commitbfb456c
File tree
4 files changed
+328
-125
lines changed- src
- backend/parser
- include/parser
- test/regress
- expected
- sql
4 files changed
+328
-125
lines changed0 commit comments
Comments
(0)