NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commitb72b4fa

committed

pg_dump: Fix dumping of WITH OIDS tables

A table with OIDs that was the first in the dump output would not getdumped with OIDs enabled. Fix that.The reason was that the currWithOids flag was declared to be bool butactually also takes a -1 value for "don't know yet". But understdbool.h semantics, that is coerced to true, so the required SETdefault_with_oids command is not output again. Change the variabletype to char to fix that.Reported-by: Derek Nelson <derek@pipelinedb.com>

1 parentf43e679 commitb72b4faCopy full SHA for b72b4fa

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_backup_archiver.h

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_backup_archiver.h`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -346,7 +346,8 @@ struct _archiveHandle`
`346`	`346`	`charcurrUser;/ current username, or NULL if unknown */`
`347`	`347`	`charcurrSchema;/ current schema, or NULL */`
`348`	`348`	`charcurrTablespace;/ current tablespace, or NULL */`
`349`		`-boolcurrWithOids;/* current default_with_oids setting */`
	`349`	`+charcurrWithOids;/* current default_with_oids setting: true,`
	`350`	`+ * false, or -1 for unknown, forcing a SET */`
`350`	`351`
`351`	`352`	`void*lo_buf;`
`352`	`353`	`size_tlo_buf_used;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb72b4fa

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_backup_archiver.h`

0 commit comments