Commitb56818a

committed

Teach pgrowlocks to check relkind before scanning

Author: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>

1 parentfb886c1 commitb56818aCopy full SHA for b56818a

File tree

+13

-1

lines changed

+13

-1

lines changed

Lines changed: 13 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,19 @@ pgrowlocks(PG_FUNCTION_ARGS)`
`97`	`97`
`98`	`98`	`relname=PG_GETARG_TEXT_PP(0);`
`99`	`99`	`relrv=makeRangeVarFromNameList(textToQualifiedNameList(relname));`
`100`		`-rel=heap_openrv(relrv,AccessShareLock);`
	`100`	`+rel=relation_openrv(relrv,AccessShareLock);`
	`101`	`+`
	`102`	`+if (rel->rd_rel->relkind==RELKIND_PARTITIONED_TABLE)`
	`103`	`+ereport(ERROR,`
	`104`	`+(errcode(ERRCODE_WRONG_OBJECT_TYPE),`
	`105`	`+errmsg("\"%s\" is a partitioned table",`
	`106`	`+RelationGetRelationName(rel)),`
	`107`	`+errdetail("Partitioned tables do not contain rows.")));`
	`108`	`+elseif (rel->rd_rel->relkind!=RELKIND_RELATION)`
	`109`	`+ereport(ERROR,`
	`110`	`+(errcode(ERRCODE_WRONG_OBJECT_TYPE),`
	`111`	`+errmsg("\"%s\" is not a table",`
	`112`	`+RelationGetRelationName(rel))));`
`101`	`113`
`102`	`114`	`/*`
`103`	`115`	`* check permissions: must have SELECT on table or be in`

Comments

(0)