Commitb4f1408

Amit Kapila

committed

Add missing errcode() in a few ereport calls.

This will allow to specifying SQLSTATE error code for the errors in themissing places.Reported-by: Sawada MasahikoAuthor: Sawada MasahikoBackpatch-through: 9.5Discussion:https://postgr.es/m/CA+fd4k6N8EjNvZpM8nme+y+05mz-SM8Z_BgkixzkA34R+ej0Kw@mail.gmail.com

1 parentfdeeb52 commitb4f1408Copy full SHA for b4f1408

File tree

-4

lines changed

-4

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ pg_file_write_internal(text file, text data, bool replace)`
`184`	`184`
`185`	`185`	`if (stat(filename,&fst) >=0)`
`186`	`186`	`ereport(ERROR,`
`187`		`-(ERRCODE_DUPLICATE_FILE,`
	`187`	`+(errcode(ERRCODE_DUPLICATE_FILE),`
`188`	`188`	`errmsg("file \"%s\" exists",filename)));`
`189`	`189`
`190`	`190`	`f=AllocateFile(filename,"wb");`
`@@ -340,7 +340,7 @@ pg_file_rename_internal(text file1, text file2, text *file3)`
`340`	`340`	`if (rc >=0\|\|errno!=ENOENT)`
`341`	`341`	`{`
`342`	`342`	`ereport(ERROR,`
`343`		`-(ERRCODE_DUPLICATE_FILE,`
	`343`	`+(errcode(ERRCODE_DUPLICATE_FILE),`
`344`	`344`	`errmsg("cannot rename to target file \"%s\"",`
`345`	`345`	`fn3 ?fn3 :fn2)));`
`346`	`346`	`}`
`@@ -371,7 +371,7 @@ pg_file_rename_internal(text file1, text file2, text *file3)`
`371`	`371`	`else`
`372`	`372`	`{`
`373`	`373`	`ereport(ERROR,`
`374`		`-(ERRCODE_UNDEFINED_FILE,`
	`374`	`+(errcode(ERRCODE_UNDEFINED_FILE),`
`375`	`375`	`errmsg("renaming \"%s\" to \"%s\" was reverted",`
`376`	`376`	`fn2,fn3)));`
`377`	`377`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ PageIsVerified(Page page, BlockNumber blkno)`
`141`	`141`	`if (checksum_failure)`
`142`	`142`	`{`
`143`	`143`	`ereport(WARNING,`
`144`		`-(ERRCODE_DATA_CORRUPTED,`
	`144`	`+(errcode(ERRCODE_DATA_CORRUPTED),`
`145`	`145`	`errmsg("page verification failed, calculated checksum %u but expected %u",`
`146`	`146`	`checksum,p->pd_checksum)));`
`147`	`147`

Comments

(0)