NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commitb2d6980

committed

Remove surplus call to table_finish_bulk_insert

4de6024 added the call to table_finish_bulk_insert to theCopyMultiInsertBufferCleanup function. We use a CopyMultiInsertBuffer evenfor non-partitioned tables, so having the cleanup do that meant we wouldcall table_finsh_bulk_insert twice when performing COPY FROM witha non-partitioned table.Here we can just remove the direct call in CopyFrom and letCopyMultiInsertBufferCleanup handle the call instead.

1 parent4de6024 commitb2d6980Copy full SHA for b2d6980

File tree

1 file changed

-2

lines changed

src/backend/commands
- copy.c

1 file changed

-2

lines changed

`‎src/backend/commands/copy.c`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3369,8 +3369,6 @@ CopyFrom(CopyState cstate)`
`3369`	`3369`
`3370`	`3370`	`if (insertMethod!=CIM_SINGLE)`
`3371`	`3371`	`{`
`3372`		`-table_finish_bulk_insert(cstate->rel,ti_options);`
`3373`		`-`
`3374`	`3372`	`/* Tear down the multi-insert buffer data */`
`3375`	`3373`	`CopyMultiInsertInfoCleanup(&multiInsertInfo);`
`3376`	`3374`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb2d6980

File tree

1 file changed

1 file changed

`‎src/backend/commands/copy.c`

0 commit comments