NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commitb281ea8

committed

Whole-row references were broken for subqueries and functions, because

attr_needed/attr_widths optimization failed to allow for Vars with attnozero in this case. Per report from Tatsuo Ishii.

1 parent918b158 commitb281ea8Copy full SHA for b281ea8

File tree

1 file changed

-14

lines changed

src/backend/optimizer/util
- relnode.c

1 file changed

-14

lines changed

`‎src/backend/optimizer/util/relnode.c‎`

Lines changed: 8 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/optimizer/util/relnode.c,v 1.53 2003/11/2919:51:51 pgsql Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/optimizer/util/relnode.c,v 1.54 2003/12/08 18:19:58 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -161,7 +161,8 @@ make_base_rel(Query *root, int relid)`
`161`	`161`	`caseRTE_SUBQUERY:`
`162`	`162`	`caseRTE_FUNCTION:`
`163`	`163`	`/* Subquery or function --- need only set up attr range */`
`164`		`-rel->min_attr=1;`
	`164`	`+/* Note: 0 is included in range to support whole-row Vars */`
	`165`	`+rel->min_attr=0;`
`165`	`166`	`rel->max_attr=length(rte->eref->colnames);`
`166`	`167`	`break;`
`167`	`168`	`default:`
`@@ -170,18 +171,11 @@ make_base_rel(Query *root, int relid)`
`170`	`171`	`break;`
`171`	`172`	`}`
`172`	`173`
`173`		`-if (rel->max_attr >=rel->min_attr)`
`174`		`-{`
`175`		`-rel->attr_needed= (Relids*)`
`176`		`-palloc0((rel->max_attr-rel->min_attr+1)*sizeof(Relids));`
`177`		`-rel->attr_widths= (int32*)`
`178`		`-palloc0((rel->max_attr-rel->min_attr+1)*sizeof(int32));`
`179`		`-}`
`180`		`-else`
`181`		`-{`
`182`		`-rel->attr_needed=NULL;`
`183`		`-rel->attr_widths=NULL;`
`184`		`-}`
	`174`	`+Assert(rel->max_attr >=rel->min_attr);`
	`175`	`+rel->attr_needed= (Relids*)`
	`176`	`+palloc0((rel->max_attr-rel->min_attr+1)*sizeof(Relids));`
	`177`	`+rel->attr_widths= (int32*)`
	`178`	`+palloc0((rel->max_attr-rel->min_attr+1)*sizeof(int32));`
`185`	`179`
`186`	`180`	`returnrel;`
`187`	`181`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb281ea8

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/util/relnode.c‎`

0 commit comments