Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitad1b5c8

Browse files
committed
Ignore old stats file timestamps when starting the stats collector.
The stats collector disregards inquiry messages that bear a cutoff_timebefore when it last wrote the relevant stats file. That's fine, but atstartup when it reads the "permanent" stats files, it absorbed theirtimestamps as if they were the times at which the corresponding temporarystats files had been written. In reality, of course, there's no dataout there at all. This led to disregarding inquiry messages soon afterstartup if the postmaster had been shut down and restarted within lessthan PGSTAT_STAT_INTERVAL; which is a pretty common scenario, both fortesting and in the field. Requesting backends would hang for 10 secondsand then report failure to read statistics, unless they got bailed outby some other backend coming along and making a newer request withinthat interval.I came across this through investigating unexpected delays in thesrc/test/recovery TAP tests: it manifests there because the autovacuumlauncher hangs for 10 seconds when it can't get statistics at startup,thus preventing a second shutdown from occurring promptly. We mightwant to do some things in the autovac code to make it less prone togetting stuck that way, but this change is a good bug fix regardless.In passing, also fix pgstat_read_statsfiles() to ensure that itre-zeroes its global stats variables if they are corrupted by ashort read from the stats file. (Other reads in that functiongo into temp variables, so that the issue doesn't arise.)This has been broken since we created the separation between permanentand temporary stats files in 8.4, so back-patch to all supported branches.Discussion:https://postgr.es/m/16860.1498442626@sss.pgh.pa.us
1 parentc61559e commitad1b5c8

File tree

1 file changed

+21
-0
lines changed

1 file changed

+21
-0
lines changed

‎src/backend/postmaster/pgstat.c

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4947,16 +4947,28 @@ pgstat_read_statsfiles(Oid onlydb, bool permanent, bool deep)
49474947
{
49484948
ereport(pgStatRunningInCollector ?LOG :WARNING,
49494949
(errmsg("corrupted statistics file \"%s\"",statfile)));
4950+
memset(&globalStats,0,sizeof(globalStats));
49504951
gotodone;
49514952
}
49524953

4954+
/*
4955+
* In the collector, disregard the timestamp we read from the permanent
4956+
* stats file; we should be willing to write a temp stats file immediately
4957+
* upon the first request from any backend. This only matters if the old
4958+
* file's timestamp is less than PGSTAT_STAT_INTERVAL ago, but that's not
4959+
* an unusual scenario.
4960+
*/
4961+
if (pgStatRunningInCollector)
4962+
globalStats.stats_timestamp=0;
4963+
49534964
/*
49544965
* Read archiver stats struct
49554966
*/
49564967
if (fread(&archiverStats,1,sizeof(archiverStats),fpin)!=sizeof(archiverStats))
49574968
{
49584969
ereport(pgStatRunningInCollector ?LOG :WARNING,
49594970
(errmsg("corrupted statistics file \"%s\"",statfile)));
4971+
memset(&archiverStats,0,sizeof(archiverStats));
49604972
gotodone;
49614973
}
49624974

@@ -5001,6 +5013,15 @@ pgstat_read_statsfiles(Oid onlydb, bool permanent, bool deep)
50015013
dbentry->tables=NULL;
50025014
dbentry->functions=NULL;
50035015

5016+
/*
5017+
* In the collector, disregard the timestamp we read from the
5018+
* permanent stats file; we should be willing to write a temp
5019+
* stats file immediately upon the first request from any
5020+
* backend.
5021+
*/
5022+
if (pgStatRunningInCollector)
5023+
dbentry->stats_timestamp=0;
5024+
50045025
/*
50055026
* Don't create tables/functions hashtables for uninteresting
50065027
* databases.

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp