NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commita6888fd

committed

Refactor timestamp2timestamptz_opt_error()

While casting from timestamp to timestamptz we do timestamp2tm() thentm2timestamp(). This commit eliminates call to tm2timestamp(). Instead, itdirectly applies timezone offset to the original timestamp value. That makesupcoming datetime overflow handling in jsonpath easier. That should also saveus some CPU cycles.Discussion:https://postgr.es/m/CAPpHfdvRPRh_mTGar5WmDeRZ%3DU5dOXHdxspYYD%3D76m3knNGjXA%40mail.gmail.comAuthor: Alexander KorotkovReviewed-by: Tom Lane

1 parentdb477b6 commita6888fdCopy full SHA for a6888fd

File tree

1 file changed

+10

-1

lines changed

src/backend/utils/adt
- timestamp.c

1 file changed

+10

-1

lines changed

`‎src/backend/utils/adt/timestamp.c`

Lines changed: 10 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5210,8 +5210,17 @@ timestamp2timestamptz_opt_error(Timestamp timestamp, bool *have_error)`
`5210`	`5210`	`{`
`5211`	`5211`	`tz=DetermineTimeZoneOffset(tm,session_timezone);`
`5212`	`5212`
`5213`		`-if (!tm2timestamp(tm,fsec,&tz,&result))`
	`5213`	`+result=dt2local(timestamp,-tz);`
	`5214`	`+`
	`5215`	`+if (IS_VALID_TIMESTAMP(result))`
	`5216`	`+{`
`5214`	`5217`	`returnresult;`
	`5218`	`+}`
	`5219`	`+elseif (have_error)`
	`5220`	`+{`
	`5221`	`+*have_error= true;`
	`5222`	`+return (TimestampTz)0;`
	`5223`	`+}`
`5215`	`5224`	`}`
`5216`	`5225`
`5217`	`5226`	`if (have_error)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita6888fd

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/timestamp.c`

0 commit comments