Commita63521e

Alexander Korotkov

committed

Prevent leaking tuples from tuplesort.

1 parent35f40f1 commita63521eCopy full SHA for a63521e

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2257,6 +2257,7 @@ insertScanItem(RumScanOpaque so, bool recheck)`
`2257`	`2257`	`j++;`
`2258`	`2258`	`}`
`2259`	`2259`	`rum_tuplesort_putrum(so->sortstate,item);`
	`2260`	`+pfree(item);`
`2260`	`2261`	`}`
`2261`	`2262`
`2262`	`2263`	`bool`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,10 @@ freeScanKeys(RumScanOpaque so)`
`303`	`303`	`}`
`304`	`304`
`305`	`305`	`pfree(so->entries);`
	`306`	`+if (so->sortedEntries)`
	`307`	`+pfree(so->sortedEntries);`
`306`	`308`	`so->entries=NULL;`
	`309`	`+so->sortedEntries=NULL;`
`307`	`310`	`so->totalentries=0;`
`308`	`311`	`}`
`309`	`312`
`@@ -415,6 +418,7 @@ rumNewScanKey(IndexScanDesc scan)`
`415`	`418`	`so->allocentries=32;`
`416`	`419`	`so->entries= (RumScanEntry*)`
`417`	`420`	`palloc0(so->allocentries*sizeof(RumScanEntry));`
	`421`	`+so->sortedEntries=NULL;`
`418`	`422`
`419`	`423`	`so->isVoidRes= false;`
`420`	`424`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1536,12 +1536,15 @@ rum_tuplesort_putrum(Tuplesortstate state, RumSortItem item)`
`1536`	`1536`	`{`
`1537`	`1537`	`MemoryContextoldcontext=MemoryContextSwitchTo(state->sortcontext);`
`1538`	`1538`	`SortTuplestup;`
	`1539`	`+RumSortItem*itemCopy=palloc(RumSortItemSize(state->nKeys));`
	`1540`	`+`
	`1541`	`+memcpy(itemCopy,item,RumSortItemSize(state->nKeys));`
`1539`	`1542`
`1540`	`1543`	`/*`
`1541`	`1544`	`* Copy the given tuple into memory we control, and decrease availMem.`
`1542`	`1545`	`* Then call the common code.`
`1543`	`1546`	`*/`
`1544`		`-COPYTUP(state,&stup, (void*)item);`
	`1547`	`+COPYTUP(state,&stup, (void*)itemCopy);`
`1545`	`1548`
`1546`	`1549`	`puttuple_common(state,&stup);`
`1547`	`1550`

Comments

(0)