@@ -177,3 +177,41 @@ SELECT * FROM connectby('connectby_int', 'keyid', 'parent_keyid', '2', 0) AS t(k
177177 9 | 5 | 2
178178(6 rows)
179179
180+ -- recursion detection
181+ INSERT INTO connectby_int VALUES(10,9);
182+ INSERT INTO connectby_int VALUES(11,10);
183+ INSERT INTO connectby_int VALUES(9,11);
184+ -- should fail due to infinite recursion
185+ SELECT * FROM connectby('connectby_int', 'keyid', 'parent_keyid', '2', 0, '~') AS t(keyid int, parent_keyid int, level int, branch text);
186+ ERROR: infinite recursion detected
187+ -- infinite recursion failure avoided by depth limit
188+ SELECT * FROM connectby('connectby_int', 'keyid', 'parent_keyid', '2', 4, '~') AS t(keyid int, parent_keyid int, level int, branch text);
189+ keyid | parent_keyid | level | branch
190+ -------+--------------+-------+-------------
191+ 2 | | 0 | 2
192+ 4 | 2 | 1 | 2~4
193+ 6 | 4 | 2 | 2~4~6
194+ 8 | 6 | 3 | 2~4~6~8
195+ 5 | 2 | 1 | 2~5
196+ 9 | 5 | 2 | 2~5~9
197+ 10 | 9 | 3 | 2~5~9~10
198+ 11 | 10 | 4 | 2~5~9~10~11
199+ (8 rows)
200+
201+ -- test for falsely detected recursion
202+ DROP TABLE connectby_int;
203+ CREATE TABLE connectby_int(keyid int, parent_keyid int);
204+ INSERT INTO connectby_int VALUES(11,NULL);
205+ INSERT INTO connectby_int VALUES(10,11);
206+ INSERT INTO connectby_int VALUES(111,11);
207+ INSERT INTO connectby_int VALUES(1,111);
208+ -- this should not fail due to recursion detection
209+ SELECT * FROM connectby('connectby_int', 'keyid', 'parent_keyid', '11', 0, '-') AS t(keyid int, parent_keyid int, level int, branch text);
210+ keyid | parent_keyid | level | branch
211+ -------+--------------+-------+----------
212+ 11 | | 0 | 11
213+ 10 | 11 | 1 | 11-10
214+ 111 | 11 | 1 | 11-111
215+ 1 | 111 | 2 | 11-111-1
216+ (4 rows)
217+