NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commita2de017

committed

Do not require 'public' to exist for pg_dump -c

Commit330b84d didn't contemplate the case where the public schemahas been dropped and introduced a query which fails when there is nopublic schema into pg_dump (when used with -c).Adjust the query used by pg_dump to handle the case where the publicschema doesn't exist and add tests to check that such a case no longerfails.Back-patch the specific fix to 9.6, as the prior commit was.Adding tests for this case involved adding support to the pg_dumpTAP tests to work with multiple databases, which, while not a largechange, is a bit much to back-patch, so that's only done in master.Addresses bug #14650Discussion:https://www.postgresql.org/message-id/20170512181801.1795.47483%40wrigleys.postgresql.org

1 parent55968ed commita2de017Copy full SHA for a2de017

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3659,9 +3659,14 @@ getNamespaces(Archive fout, int numNamespaces)`
`3659`	`3659`	`* essentially a no-op because the new public schema won't have an`
`3660`	`3660`	`* entry in pg_init_privs anyway, as the entry will be removed when`
`3661`	`3661`	`* the public schema is dropped.`
	`3662`	`+ *`
	`3663`	`+ * Further, we have to handle the case where the public schema does`
	`3664`	`+ * not exist at all.`
`3662`	`3665`	`*/`
`3663`	`3666`	`if (dopt->outputClean)`
`3664`		`-appendPQExpBuffer(query," AND pip.objoid <> 'public'::regnamespace");`
	`3667`	`+appendPQExpBuffer(query," AND pip.objoid <> "`
	`3668`	`+"coalesce((select oid from pg_namespace "`
	`3669`	`+"where nspname = 'public'),0)");`
`3665`	`3670`
`3666`	`3671`	`appendPQExpBuffer(query,") ");`
`3667`	`3672`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commita2de017

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments