Commita25d308

Sokolov Yura

committed

cfs: memset_hole in a page

clear hole between pd_lower and pd_upper of a page, so compression canefficiently eliminate this wasted space.

1 parent21654b5 commita25d308Copy full SHA for a25d308

File tree

+14

-0

lines changed

+14

-0

lines changed

Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -485,6 +485,17 @@ compactify_tuples(itemIdSort itemidbase, int nitems, Page page)`
`485`	`485`	`phdr->pd_upper=upper;`
`486`	`486`	`}`
`487`	`487`
	`488`	`+/*`
	`489`	`+ * Clean up space between pd_lower and pd_upper for better page compression.`
	`490`	`+ */`
	`491`	`+staticvoid`
	`492`	`+memset_hole(Pagepage)`
	`493`	`+{`
	`494`	`+PageHeaderphdr= (PageHeader)page;`
	`495`	`+if (phdr->pd_upper>phdr->pd_lower)`
	`496`	`+memset((char*)page+phdr->pd_lower,0,phdr->pd_upper-phdr->pd_lower);`
	`497`	`+}`
	`498`	`+`
`488`	`499`	`/*`
`489`	`500`	`* PageRepairFragmentation`
`490`	`501`	`*`
`@@ -582,6 +593,7 @@ PageRepairFragmentation(Page page)`
`582`	`593`
`583`	`594`	`compactify_tuples(itemidbase,nstorage,page);`
`584`	`595`	`}`
	`596`	`+memset_hole(page);`
`585`	`597`
`586`	`598`	`/* Set hint bit for PageAddItem */`
`587`	`599`	`if (nunused>0)`
`@@ -931,6 +943,7 @@ PageIndexMultiDelete(Page page, OffsetNumber *itemnos, int nitems)`
`931`	`943`
`932`	`944`	`/* and compactify the tuple data */`
`933`	`945`	`compactify_tuples(itemidbase,nused,page);`
	`946`	`+memset_hole(page);`
`934`	`947`	`}`
`935`	`948`
`936`	`949`	`/*`
`@@ -1083,6 +1096,7 @@ PageIndexDeleteNoCompact(Page page, OffsetNumber *itemnos, int nitems)`
`1083`	`1096`	`*/`
`1084`	`1097`	`compactify_tuples(itemidbase,nline,page);`
`1085`	`1098`	`}`
	`1099`	`+memset_hole(page);`
`1086`	`1100`	`}`
`1087`	`1101`
`1088`	`1102`	`/*`

Comments

(0)