Commita0e253b

authored and

committed

Fix recovery completed message handling

1 parent6f5342c commita0e253bCopy full SHA for a0e253b

File tree

-5

lines changed

-5

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3293,6 +3293,7 @@ void MtmRecoverNode(int nodeId)`
`3293`	`3293`	`{`
`3294`	`3294`	`Assert(BIT_CHECK(Mtm->disabledNodeMask,nodeId-1));`
`3295`	`3295`	`BIT_CLEAR(Mtm->stoppedNodeMask,nodeId-1);`
	`3296`	`+BIT_CLEAR(Mtm->stalledNodeMask,nodeId-1);`
`3296`	`3297`	`}`
`3297`	`3298`	`MtmUnlock();`
`3298`	`3299`
`@@ -3551,8 +3552,8 @@ MtmReplicationRowFilterHook(struct PGLogicalRowFilterArgs* args)`
`3551`	`3552`	`* Filter received transactions at destination side.`
`3552`	`3553`	`* This function is executed by receiver,`
`3553`	`3554`	`* so there are no race conditions and it is possible to update nodes[i].restartLSN without lock.`
`3554`		`- * It is more efficient to filter records at senders size (done by MtmReplicationTxnFilterHook) to avoid sending useless data through network.But asynchronous nature of`
`3555`		`- * logical replications makes it not possible to guarantee (at least I failed to do it)`
	`3555`	`+ * It is more efficient to filter records at senders size (done by MtmReplicationTxnFilterHook) to avoid sending useless data through network.`
	`3556`	`+ *But asynchronous nature oflogical replications makes it not possible to guarantee (at least I failed to do it)`
`3556`	`3557`	`* that replica do not receive deteriorated data.`
`3557`	`3558`	`*/`
`3558`	`3559`	`boolMtmFilterTransaction(char*record,intsize)`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1119,7 +1119,7 @@ void MtmExecutor(void* work, size_t size)`
`1119`	`1119`	`case'Z':`
`1120`	`1120`	`{`
`1121`	`1121`	`MtmRecoveryCompleted();`
`1122`		`-continue;`
	`1122`	`+break;`
`1123`	`1123`	`}`
`1124`	`1124`	`default:`
`1125`	`1125`	`elog(ERROR,"unknown action of type %c",action);`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,7 @@ pglogical_write_commit(StringInfo out, PGLogicalOutputData *data,`
`182`	`182`	`{`
`183`	`183`	`uint8event=0;`
`184`	`184`
`185`		`-MTM_LOG1("%d: pglogical_write_commit XID=%ld node=%d restart_decoding_lsn=%lx first_lsn=%lx end_lsn=%lx confirmed_flush=%lx",`
	`185`	`+MTM_LOG2("%d: pglogical_write_commit XID=%ld node=%d restart_decoding_lsn=%lx first_lsn=%lx end_lsn=%lx confirmed_flush=%lx",`
`186`	`186`	`MyProcPid, (long)txn->xid,MtmReplicationNodeId,txn->restart_decoding_lsn,txn->first_lsn,txn->end_lsn,MyReplicationSlot->data.confirmed_flush);`
`187`	`187`
`188`	`188`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@ def tearDownClass(self):`
`87`	`87`	`print('tearDown')`
`88`	`88`	`self.client.stop()`
`89`	`89`	`# XXX: check nodes data identity here`
`90`		`-subprocess.check_call(['docker-compose','down'])`
	`90`	`+# subprocess.check_call(['docker-compose','down'])`
`91`	`91`
`92`	`92`	`defsetUp(self):`
`93`	`93`	`warnings.simplefilter("ignore",ResourceWarning)`

Comments

(0)