Commit9e8bfc7

committed

check that table is partitioned by RANGE in create_single_range_partition()

1 parent0184282 commit9e8bfc7Copy full SHA for 9e8bfc7

File tree

+31

-2

lines changed

+31

-2

lines changed

Lines changed: 12 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -102,8 +102,19 @@ SELECT count(*) FROM calamity.part_test;`
`102`	`102`
`103`	`103`	`DELETE FROM calamity.part_test;`
`104`	`104`	`/* test function create_single_range_partition() */`
`105`		`-SELECT create_single_range_partition(NULL, NULL::INT4, NULL);/* not ok */`
	`105`	`+SELECT create_single_range_partition(NULL, NULL::INT4, NULL);/* not ok */`
`106`	`106`	`ERROR: 'parent_relid' should not be NULL`
	`107`	`+SELECT create_single_range_partition('pg_class', NULL::INT4, NULL);/* not ok */`
	`108`	`+ERROR: table "pg_class" is not partitioned by RANGE`
	`109`	`+SELECT add_to_pathman_config('calamity.part_test', 'val');`
	`110`	`+ add_to_pathman_config`
	`111`	`+-----------------------`
	`112`	`+ t`
	`113`	`+(1 row)`
	`114`	`+`
	`115`	`+SELECT create_single_range_partition('calamity.part_test', NULL::INT4, NULL);/* not ok */`
	`116`	`+ERROR: table "part_test" is not partitioned by RANGE`
	`117`	`+DELETE FROM pathman_config WHERE partrel = 'calamity.part_test'::REGCLASS;`
`107`	`118`	`/* test function create_range_partitions_internal() */`
`108`	`119`	`SELECT create_range_partitions_internal(NULL, '{}'::INT[], NULL, NULL);/* not ok */`
`109`	`120`	`ERROR: 'parent_relid' should not be NULL`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,13 @@ DELETE FROM calamity.part_test;`
`37`	`37`
`38`	`38`
`39`	`39`	`/* test function create_single_range_partition()*/`
`40`		`-SELECT create_single_range_partition(NULL,NULL::INT4,NULL);/* not ok*/`
	`40`	`+SELECT create_single_range_partition(NULL,NULL::INT4,NULL);/* not ok*/`
	`41`	`+SELECT create_single_range_partition('pg_class',NULL::INT4,NULL);/* not ok*/`
	`42`	`+`
	`43`	`+SELECT add_to_pathman_config('calamity.part_test','val');`
	`44`	`+SELECT create_single_range_partition('calamity.part_test',NULL::INT4,NULL);/* not ok*/`
	`45`	`+DELETEFROM pathman_configWHERE partrel='calamity.part_test'::REGCLASS;`
	`46`	`+`
`41`	`47`
`42`	`48`	`/* test function create_range_partitions_internal()*/`
`43`	`49`	`SELECT create_range_partitions_internal(NULL,'{}'::INT[],NULL,NULL);/* not ok*/`

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,9 @@ create_single_range_partition_pl(PG_FUNCTION_ARGS)`
`100`	`100`	`RangeVar*partition_name_rv;`
`101`	`101`	`char*tablespace;`
`102`	`102`
	`103`	`+Datumvalues[Natts_pathman_config];`
	`104`	`+boolisnull[Natts_pathman_config];`
	`105`	`+`
`103`	`106`
`104`	`107`	`/* Handle 'parent_relid' */`
`105`	`108`	`if (!PG_ARGISNULL(0))`
`@@ -109,6 +112,15 @@ create_single_range_partition_pl(PG_FUNCTION_ARGS)`
`109`	`112`	`elseereport(ERROR, (errcode(ERRCODE_INVALID_PARAMETER_VALUE),`
`110`	`113`	`errmsg("'parent_relid' should not be NULL")));`
`111`	`114`
	`115`	`+/* Check that table is partitioned by RANGE */`
	`116`	`+if (!pathman_config_contains_relation(parent_relid,values,isnull,NULL,NULL)\|\|`
	`117`	`+DatumGetPartType(values[Anum_pathman_config_parttype-1])!=PT_RANGE)`
	`118`	`+{`
	`119`	`+ereport(ERROR, (errcode(ERRCODE_INVALID_PARAMETER_VALUE),`
	`120`	`+errmsg("table \"%s\" is not partitioned by RANGE",`
	`121`	`+get_rel_name_or_relid(parent_relid))));`
	`122`	`+}`
	`123`	`+`
`112`	`124`	`bounds_type=get_fn_expr_argtype(fcinfo->flinfo,1);`
`113`	`125`
`114`	`126`	`start=PG_ARGISNULL(1) ?`

Comments

(0)