Commit9b8e7c3

committed

Touch global snapshots csn->xmin map only when track_global_snapshots.

Actually we should allow this -- it might make sense for hot standby.(cherry picked from commit 109b20b09e3b7e10015ffa13b7b8cd71345ddfea)

1 parent37862be commit9b8e7c3Copy full SHA for 9b8e7c3

File tree

-2

lines changed

src/backend
- access/transam
  - global_snapshot.c
- storage/ipc
  - procarray.c

-2

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,8 @@ GlobalSnapshotStartup(TransactionId oldestActiveXID)`
`181`	`181`	`* Run only if we have initialized shared memory and gsXidMap`
`182`	`182`	`* is enabled.`
`183`	`183`	`*/`
`184`		`-if (IsNormalProcessingMode()&&global_snapshot_defer_time>0)`
	`184`	`+if (IsNormalProcessingMode()&&track_global_snapshots&&`
	`185`	`+global_snapshot_defer_time>0)`
`185`	`186`	`{`
`186`	`187`	`inti;`
`187`	`188`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1847,7 +1847,8 @@ GetSnapshotData(Snapshot snapshot)`
`1847`	`1847`	`snapshot->imported_global_csn= false;`
`1848`	`1848`	`snapshot->global_csn=global_csn;`
`1849`	`1849`	`/* if (global_snapshot_defer_time > 0 && IsNormalProcessingMode()) */`
`1850`		`-if (global_snapshot_defer_time>0&&IsUnderPostmaster)`
	`1850`	`+if (track_global_snapshots&&global_snapshot_defer_time>0&&`
	`1851`	`+IsUnderPostmaster)`
`1851`	`1852`	`GlobalSnapshotMapXmin(snapshot->global_csn);`
`1852`	`1853`
`1853`	`1854`	`returnsnapshot;`

Comments

(0)