Commit992a7ad

committed

improve function pathman_update_trigger_func_move_tuple()

1 parent2604a1c commit992a7adCopy full SHA for 992a7ad

File tree

+14

-3

lines changed

+14

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,7 @@ build_part_tuple_map(Relation parent_rel, Relation child_rel)`
`344`	`344`	`TupleDescchild_tupdesc,`
`345`	`345`	`parent_tupdesc;`
`346`	`346`
`347`		`-/Use fake 'tdtypeid' in order to fool convert_tuples_by_name() /`
	`347`	`+/HACK: use fake 'tdtypeid' in order to fool convert_tuples_by_name() /`
`348`	`348`	`child_tupdesc=CreateTupleDescCopy(RelationGetDescr(child_rel));`
`349`	`349`	`child_tupdesc->tdtypeid=InvalidOid;`
`350`	`350`

Lines changed: 13 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1212,11 +1212,18 @@ pathman_update_trigger_func_move_tuple(Relation source_rel,`
`1212`	`1212`	`HeapTupleold_tuple,`
`1213`	`1213`	`HeapTuplenew_tuple)`
`1214`	`1214`	`{`
`1215`		`-TupleDescsource_tupdesc=RelationGetDescr(source_rel),`
`1216`		`-target_tupdesc=RelationGetDescr(target_rel);`
	`1215`	`+TupleDescsource_tupdesc,`
	`1216`	`+target_tupdesc;`
`1217`	`1217`	`HeapTupletarget_tuple;`
`1218`	`1218`	`TupleConversionMap*conversion_map;`
`1219`	`1219`
	`1220`	`+/* HACK: use fake 'tdtypeid' in order to fool convert_tuples_by_name() */`
	`1221`	`+source_tupdesc=CreateTupleDescCopy(RelationGetDescr(source_rel));`
	`1222`	`+source_tupdesc->tdtypeid=InvalidOid;`
	`1223`	`+`
	`1224`	`+target_tupdesc=CreateTupleDescCopy(RelationGetDescr(target_rel));`
	`1225`	`+target_tupdesc->tdtypeid=InvalidOid;`
	`1226`	`+`
`1220`	`1227`	`/* Build tuple conversion map */`
`1221`	`1228`	`conversion_map=convert_tuples_by_name(source_tupdesc,`
`1222`	`1229`	`target_tupdesc,`
`@@ -1286,6 +1293,10 @@ pathman_update_trigger_func_move_tuple(Relation source_rel,`
`1286`	`1293`	`}`
`1287`	`1294`	`/* Else emit error */`
`1288`	`1295`	`elseelog(ERROR,"could not connect using SPI");`
	`1296`	`+`
	`1297`	`+/* At last, free these temporary tuple descs */`
	`1298`	`+FreeTupleDesc(source_tupdesc);`
	`1299`	`+FreeTupleDesc(target_tupdesc);`
`1289`	`1300`	`}`
`1290`	`1301`
`1291`	`1302`	`/* Create UPDATE triggers for all partitions */`

Comments

(0)