NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit98d476a

Amit Kapila

committed

Improve coding pattern in Parallel Append code.

The create_append_path code didn't consider that list_concat willmodify it's first argument leading to inconsistent traversal ofresulting list. In practice, it won't lead to any user-visible bugbut changing it for making the code behave consistently.Reported-by: Tom LaneAuthor: Tom LaneReviewed-by: Amit Khandekar and Amit KapilaDiscussion:https://postgr.es/m/32365.1528994120@sss.pgh.pa.us

1 parentc704897 commit98d476aCopy full SHA for 98d476a

File tree

1 file changed

-1

lines changed

src/backend/optimizer/util
- pathnode.c

1 file changed

-1

lines changed

`‎src/backend/optimizer/util/pathnode.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1274,7 +1274,7 @@ create_append_path(PlannerInfo *root,`
`1274`	`1274`	`pathnode->first_partial_path=list_length(subpaths);`
`1275`	`1275`	`pathnode->subpaths=list_concat(subpaths,partial_subpaths);`
`1276`	`1276`
`1277`		`-foreach(l,subpaths)`
	`1277`	`+foreach(l,pathnode->subpaths)`
`1278`	`1278`	`{`
`1279`	`1279`	`Pathsubpath= (Path)lfirst(l);`
`1280`	`1280`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit98d476a

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/util/pathnode.c`

0 commit comments