Commit9709678

Arthur Zakirov

committed

Fix using uninitialized backup_files_list

1 parentc831b99 commit9709678Copy full SHA for 9709678

File tree

+10

-7

lines changed

+10

-7

lines changed

Lines changed: 10 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -382,9 +382,9 @@ do_backup_database(parray *backup_list)`
`382`	`382`	`current.data_bytes+=file->write_size;`
`383`	`383`	`}`
`384`	`384`
`385`		`-if (backup_files_list)`
`386`		`-parray_walk(backup_files_list,pgFileFree);`
	`385`	`+parray_walk(backup_files_list,pgFileFree);`
`387`	`386`	`parray_free(backup_files_list);`
	`387`	`+backup_files_list=NULL;`
`388`	`388`	`}`
`389`	`389`
`390`	`390`	`/*`
`@@ -1155,11 +1155,14 @@ pg_stop_backup(pgBackup *backup)`
`1155`	`1155`	`elog(ERROR,"can't write tablespace map file \"%s\": %s",`
`1156`	`1156`	`tablespace_map,strerror(errno));`
`1157`	`1157`
`1158`		`-file=pgFileNew(tablespace_map, true);`
`1159`		`-calc_file_checksum(file);`
`1160`		`-free(file->path);`
`1161`		`-file->path=strdup(PG_TABLESPACE_MAP_FILE);`
`1162`		`-parray_append(backup_files_list,file);`
	`1158`	`+if (backup_files_list)`
	`1159`	`+{`
	`1160`	`+file=pgFileNew(tablespace_map, true);`
	`1161`	`+calc_file_checksum(file);`
	`1162`	`+free(file->path);`
	`1163`	`+file->path=strdup(PG_TABLESPACE_MAP_FILE);`
	`1164`	`+parray_append(backup_files_list,file);`
	`1165`	`+}`
`1163`	`1166`	`}`
`1164`	`1167`
`1165`	`1168`	`if (sscanf(PQgetvalue(res,0,3),XID_FMT,&recovery_xid)!=1)`

Comments

(0)