NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit921059b

committed

Don't allow VACUUM VERBOSE ANALYZE VERBOSE.

There are plans to extend the syntax for ANALYZE, so we need to breakthe link between VacuumStmt and AnalyzeStmt. But apart from that, thesyntax above is undocumented and, if discovered by users, might givethe impression that the VERBOSE option for VACUUM differs from theverbose option from ANALYZE, which it does not.Nathan Bossart, reviewed by Michael Paquier and Masahiko SawadaDiscussion:http://postgr.es/m/D3FC73E2-9B1A-4DB4-8180-55F57D116B4E@amazon.com

1 parentbc7fa0c commit921059bCopy full SHA for 921059b

File tree

1 file changed

+10

-15

lines changed

src/backend/parser
- gram.y

1 file changed

+10

-15

lines changed

`‎src/backend/parser/gram.y`

Lines changed: 10 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -437,7 +437,7 @@ static Node makeRecursiveViewSelect(char relname, List aliases, Node query);`
`437`	`437`
`438`	`438`	`%type<boolean>opt_instead`
`439`	`439`	`%type<boolean>opt_uniqueopt_concurrentlyopt_verboseopt_full`
`440`		`-%type<boolean>opt_freezeopt_defaultopt_recheck`
	`440`	`+%type<boolean>opt_freezeopt_analyzeopt_defaultopt_recheck`
`441`	`441`	`%type<defelt>opt_binaryopt_oidscopy_delimiter`
`442`	`442`
`443`	`443`	`%type<boolean>copy_fromopt_program`
`@@ -10462,7 +10462,7 @@ cluster_index_specification:`
`10462`	`10462`	`*`
`10463`	`10463`	`*****************************************************************************/`
`10464`	`10464`
`10465`		`-VacuumStmt:VACUUMopt_fullopt_freezeopt_verboseopt_vacuum_relation_list`
	`10465`	`+VacuumStmt:VACUUMopt_fullopt_freezeopt_verboseopt_analyzeopt_vacuum_relation_list`
`10466`	`10466`	`{`
`10467`	`10467`	`VacuumStmt *n = makeNode(VacuumStmt);`
`10468`	`10468`	`n->options = VACOPT_VACUUM;`
`@@ -10472,19 +10472,9 @@ VacuumStmt: VACUUM opt_full opt_freeze opt_verbose opt_vacuum_relation_list`
`10472`	`10472`	`n->options \|= VACOPT_FREEZE;`
`10473`	`10473`	`if ($4)`
`10474`	`10474`	`n->options \|= VACOPT_VERBOSE;`
`10475`		`-n->rels =$5;`
`10476`		`-$$ = (Node *)n;`
`10477`		`-}`
`10478`		`-\|VACUUMopt_fullopt_freezeopt_verboseAnalyzeStmt`
`10479`		`-{`
`10480`		`-VacuumStmt n = (VacuumStmt )$5;`
`10481`		`-n->options \|= VACOPT_VACUUM;`
`10482`		`-if ($2)`
`10483`		`-n->options \|= VACOPT_FULL;`
`10484`		`-if ($3)`
`10485`		`-n->options \|= VACOPT_FREEZE;`
`10486`		`-if ($4)`
`10487`		`-n->options \|= VACOPT_VERBOSE;`
	`10475`	`+if ($5)`
	`10476`	`+n->options \|= VACOPT_ANALYZE;`
	`10477`	`+n->rels =$6;`
`10488`	`10478`	`$$ = (Node *)n;`
`10489`	`10479`	`}`
`10490`	`10480`	`\|VACUUM'('vacuum_option_list')'opt_vacuum_relation_list`
`@@ -10534,6 +10524,11 @@ analyze_keyword:`
`10534`	`10524`	`\|ANALYSE/* British*/{}`
`10535`	`10525`	`;`
`10536`	`10526`
	`10527`	`+opt_analyze:`
	`10528`	`+analyze_keyword{$$ =true; }`
	`10529`	`+\|/EMPTY/{$$ =false; }`
	`10530`	`+;`
	`10531`	`+`
`10537`	`10532`	`opt_verbose:`
`10538`	`10533`	`VERBOSE{$$ =true; }`
`10539`	`10534`	`\|/EMPTY/{$$ =false; }`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit921059b

File tree

1 file changed

1 file changed

`‎src/backend/parser/gram.y`

0 commit comments