NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit9209e07

committed

Ensure commands in extension scripts see the results of preceding DDL.

Due to a missing CommandCounterIncrement() call, parsing of a non-utilitycommand in an extension script would not see the effects of the immediatelypreceding DDL command, unless that command's execution ends withCommandCounterIncrement() internally ... which some do but many don't.Report by Philippe Beaudoin, diagnosis by Julien Rouhaud.Rather remarkably, this bug has evaded detection since extensions wereinvented, so back-patch to all supported branches.Discussion:https://postgr.es/m/2cf7941e-4e41-7714-3de8-37b1a8f74dff@free.fr

1 parent93bbeec commit9209e07Copy full SHA for 9209e07

File tree

2 files changed

-0

lines changed

src
- backend/commands
  - extension.c
- test/modules/test_extensions
  - test_ext3--1.0.sql

2 files changed

-0

lines changed

`‎src/backend/commands/extension.c`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -718,6 +718,9 @@ execute_sql_string(const char sql, const char filename)`
`718`	`718`	`List*stmt_list;`
`719`	`719`	`ListCell*lc2;`
`720`	`720`
	`721`	`+/* Be sure parser can see any DDL done so far */`
	`722`	`+CommandCounterIncrement();`
	`723`	`+`
`721`	`724`	`stmt_list=pg_analyze_and_rewrite(parsetree,`
`722`	`725`	`sql,`
`723`	`726`	`NULL,`

`‎src/test/modules/test_extensions/test_ext3--1.0.sql`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,9 @@`
`1`	`1`	`/* src/test/modules/test_extensions/test_ext3--1.0.sql*/`
`2`	`2`	`-- complain if script is sourced in psql, rather than via CREATE EXTENSION`
`3`	`3`	`\echo Use"CREATE EXTENSION test_ext3" to load this file. \quit`
	`4`	`+`
	`5`	`+CREATETABLEtest_ext3_table (col_oldINT);`
	`6`	`+`
	`7`	`+ALTERTABLE test_ext3_table RENAME col_old TO col_new;`
	`8`	`+`
	`9`	`+UPDATE test_ext3_tableSET col_new=0;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9209e07

File tree

2 files changed

2 files changed

`‎src/backend/commands/extension.c`

`‎src/test/modules/test_extensions/test_ext3--1.0.sql`

0 commit comments