NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit90fd3bf

committed

Limit depth of forced recursion for CLOBBER_CACHE_RECURSIVELY.

It's somewhat surprising that we got away with this before. (Actually,since nobody tests this routinely AFAIK, it might've been broken forawhile. But it's definitely broken in the wake of commitf868a81.)It seems sufficient to limit the forced recursion to a small numberof levels.Back-patch to all supported branches, like the preceding patch.Discussion:https://postgr.es/m/12259.1532117714@sss.pgh.pa.us

1 parent2569ca0 commit90fd3bfCopy full SHA for 90fd3bf

File tree

1 file changed

+11

-1

lines changed

src/backend/utils/cache
- inval.c

1 file changed

+11

-1

lines changed

`‎src/backend/utils/cache/inval.c`

Lines changed: 11 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -708,7 +708,17 @@ AcceptInvalidationMessages(void)`
`708`	`708`	`}`
`709`	`709`	`}`
`710`	`710`	`#elif defined(CLOBBER_CACHE_RECURSIVELY)`
`711`		`-InvalidateSystemCaches();`
	`711`	`+{`
	`712`	`+staticintrecursion_depth=0;`
	`713`	`+`
	`714`	`+/* Maximum depth is arbitrary depending on your threshold of pain */`
	`715`	`+if (recursion_depth<3)`
	`716`	`+{`
	`717`	`+recursion_depth++;`
	`718`	`+InvalidateSystemCaches();`
	`719`	`+recursion_depth--;`
	`720`	`+}`
	`721`	`+}`
`712`	`722`	`#endif`
`713`	`723`	`}`
`714`	`724`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit90fd3bf

File tree

1 file changed

1 file changed

`‎src/backend/utils/cache/inval.c`

0 commit comments