Commit89d52b9

committed

Free pre-modification HeapTuple in ALTER TABLE ... TYPE ...

This was an oversight in commit3b174b1.Per offline gripe from Alvaro HerreraBackpatch to release 11.

1 parent05eb923 commit89d52b9Copy full SHA for 89d52b9

File tree

-2

lines changed

-2

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -9747,6 +9747,7 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,`
`9747`	`9747`	`DatumvaluesAtt[Natts_pg_attribute];`
`9748`	`9748`	`boolnullsAtt[Natts_pg_attribute];`
`9749`	`9749`	`boolreplacesAtt[Natts_pg_attribute];`
	`9750`	`+HeapTuplenewTup;`
`9750`	`9751`
`9751`	`9752`	`MemSet(valuesAtt,0,sizeof(valuesAtt));`
`9752`	`9753`	`MemSet(nullsAtt, false,sizeof(nullsAtt));`
`@@ -9772,8 +9773,10 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,`
`9772`	`9773`	`replacesAtt[Anum_pg_attribute_attmissingval-1]= true;`
`9773`	`9774`	`nullsAtt[Anum_pg_attribute_attmissingval-1]= false;`
`9774`	`9775`
`9775`		`-heapTup=heap_modify_tuple(heapTup,RelationGetDescr(attrelation),`
`9776`		`-valuesAtt,nullsAtt,replacesAtt);`
	`9776`	`+newTup=heap_modify_tuple(heapTup,RelationGetDescr(attrelation),`
	`9777`	`+valuesAtt,nullsAtt,replacesAtt);`
	`9778`	`+heap_freetuple(heapTup);`
	`9779`	`+heapTup=newTup;`
`9777`	`9780`	`attTup= (Form_pg_attribute)GETSTRUCT(heapTup);`
`9778`	`9781`	`}`
`9779`	`9782`	`}`

Comments

(0)