NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit88ef48c

committed

Fix parallel index builds for dynamic_shared_memory_type=none.

The previous code failed to realize that this setting effectivelydisables parallelism, and would crash if it decided to attemptparallelism anyway. Instead, treat it as a disabling condition.Kyotaro Horiguchi, who also reported the issue. Reviewed by MichaelPaquier and Peter Geoghegan.Discussion:http://postgr.es/m/20180209.170635.256350357.horiguchi.kyotaro@lab.ntt.co.jp

1 parent80f021e commit88ef48cCopy full SHA for 88ef48c

File tree

1 file changed

-1

lines changed

src/backend/optimizer/plan
- planner.c

1 file changed

-1

lines changed

`‎src/backend/optimizer/plan/planner.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5825,7 +5825,8 @@ plan_create_index_workers(Oid tableOid, Oid indexOid)`
`5825`	`5825`	`doubleallvisfrac;`
`5826`	`5826`
`5827`	`5827`	`/* Return immediately when parallelism disabled */`
`5828`		`-if (max_parallel_maintenance_workers==0)`
	`5828`	`+if (dynamic_shared_memory_type==DSM_IMPL_NONE\|\|`
	`5829`	`+max_parallel_maintenance_workers==0)`
`5829`	`5830`	`return0;`
`5830`	`5831`
`5831`	`5832`	`/* Set up largely-dummy planner state */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit88ef48c

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/plan/planner.c`

0 commit comments