Commit85abb5b

committed

Make PGAC_C_BUILTIN_OP_OVERFLOW link instead of just compiling.

Otherwise the detection can spuriously detect symbol as available,because the compiler may just emits reference to non-existant symbol.

1 parent101c7ee commit85abb5bCopy full SHA for 85abb5b

File tree

-4

lines changed

-4

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -305,10 +305,11 @@ fi])# PGAC_C_BUILTIN_CONSTANT_P`
`305`	`305`	`# and define HAVE__BUILTIN_OP_OVERFLOW if so.`
`306`	`306`	`#`
`307`	`307`	`# Check for the most complicated case, 64 bit multiplication, as a`
`308`		`-# proxy for all of the operations.`
	`308`	`+# proxy for all of the operations. Have to link to be sure to`
	`309`	`+# recognize a missing __builtin_mul_overflow.`
`309`	`310`	`AC_DEFUN([PGAC_C_BUILTIN_OP_OVERFLOW],`
`310`	`311`	`[AC_CACHE_CHECK(for__builtin_mul_overflow,pgac_cv__builtin_op_overflow,`
`311`		`-[AC_COMPILE_IFELSE([AC_LANG_PROGRAM([],`
	`312`	`+[AC_LINK_IFELSE([AC_LANG_PROGRAM([],`
`312`	`313`	`[PG_INT64_TYPE result;`
`313`	`314`	`__builtin_mul_overflow((PG_INT64_TYPE) 1, (PG_INT64_TYPE) 2, &result);]`
`314`	`315`	`)],`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -14472,6 +14472,8 @@ esac`
`14472`	`14472`
`14473`	`14473`	`fi`
`14474`	`14474`
	`14475`	`+# has to be down here, rather than with the other builtins, because`
	`14476`	`+# the test uses PG_INT64_TYPE.`
`14475`	`14477`	`{$as_echo"$as_me:${as_lineno-$LINENO}: checking for __builtin_mul_overflow">&5`
`14476`	`14478`	`$as_echo_n"checking for __builtin_mul_overflow...">&6; }`
`14477`	`14479`	`if${pgac_cv__builtin_op_overflow+:}false;then:`
`@@ -14490,12 +14492,13 @@ __builtin_mul_overflow((PG_INT64_TYPE) 1, (PG_INT64_TYPE) 2, &result);`
`14490`	`14492`	`return 0;`
`14491`	`14493`	`}`
`14492`	`14494`	`_ACEOF`
`14493`		`-ifac_fn_c_try_compile"$LINENO";then:`
	`14495`	`+ifac_fn_c_try_link"$LINENO";then:`
`14494`	`14496`	`pgac_cv__builtin_op_overflow=yes`
`14495`	`14497`	`else`
`14496`	`14498`	`pgac_cv__builtin_op_overflow=no`
`14497`	`14499`	`fi`
`14498`		`-rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext`
	`14500`	`+rm -f core conftest.err conftest.$ac_objext \`
	`14501`	`+ conftest$ac_exeext conftest.$ac_ext`
`14499`	`14502`	`fi`
`14500`	`14503`	`{$as_echo"$as_me:${as_lineno-$LINENO}: result:$pgac_cv__builtin_op_overflow">&5`
`14501`	`14504`	`$as_echo"$pgac_cv__builtin_op_overflow">&6; }`

Comments

(0)