NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit8504905

committed

Fix a thinko introduced into CountActiveBackends by a recent patch:

we should ignore NULL array entries, not non-NULL ones. This had theeffect of disabling commit_delay, and could have caused a crash in therare race condition the patch was intended to fix.Bug report and diagnosis by Jeff Janes, in bug #4952.

1 parent49475aa commit8504905Copy full SHA for 8504905

File tree

1 file changed

-2

lines changed

src/backend/storage/ipc
- procarray.c

1 file changed

-2

lines changed

`‎src/backend/storage/ipc/procarray.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@`
`23`	`23`	`*`
`24`	`24`	`*`
`25`	`25`	`* IDENTIFICATION`
`26`		`- * $PostgreSQL: pgsql/src/backend/storage/ipc/procarray.c,v 1.50 2009/06/11 14:49:02 momjian Exp $`
	`26`	`+ * $PostgreSQL: pgsql/src/backend/storage/ipc/procarray.c,v 1.51 2009/07/29 15:57:11 tgl Exp $`
`27`	`27`	`*`
`28`	`28`	`*-------------------------------------------------------------------------`
`29`	`29`	`*/`
`@@ -1137,7 +1137,7 @@ CountActiveBackends(void)`
`1137`	`1137`	`* free list and are recycled. Its contents are nonsense in that case,`
`1138`	`1138`	`* but that's acceptable for this function.`
`1139`	`1139`	`*/`
`1140`		`-if (proc!=NULL)`
	`1140`	`+if (proc==NULL)`
`1141`	`1141`	`continue;`
`1142`	`1142`
`1143`	`1143`	`if (proc==MyProc)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit8504905

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/procarray.c`

0 commit comments