Commit84d4de9

committed

Improve some comments in pg_checksums about the needed clean shutdown

It was not clear from the code why it is necessary. And we need a cleanshutdown to avoid random checksum failures caused by torn pages.Author: Masahiko SawadaDiscussion:https://postgr.es/m/CAD21AoDum5MbAb7F=pa9dOD1W2tukuDMPzWT7NjZceNoWB_6Qw@mail.gmail.com

1 parent77b68e3 commit84d4de9Copy full SHA for 84d4de9

File tree

-1

lines changed

-1

lines changed

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -475,7 +475,7 @@ main(int argc, char *argv[])`
`475`	`475`	`exit(1);`
`476`	`476`	`}`
`477`	`477`
`478`		`-/Check if cluster is running /`
	`478`	`+/Read the control file and check compatibility /`
`479`	`479`	`ControlFile=get_controlfile(DataDir,&crc_ok);`
`480`	`480`	`if (!crc_ok)`
`481`	`481`	`{`
`@@ -497,6 +497,11 @@ main(int argc, char *argv[])`
`497`	`497`	`exit(1);`
`498`	`498`	`}`
`499`	`499`
	`500`	`+/*`
	`501`	`+ * Check if cluster is running. A clean shutdown is required to avoid`
	`502`	`+ * random checksum failures caused by torn pages. Note that this doesn't`
	`503`	`+ * guard against someone starting the cluster concurrently.`
	`504`	`+ */`
`500`	`505`	`if (ControlFile->state!=DB_SHUTDOWNED&&`
`501`	`506`	`ControlFile->state!=DB_SHUTDOWNED_IN_RECOVERY)`
`502`	`507`	`{`

Comments

(0)