NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit826eff5

committed

Ensure static libraries have correct mod time even if ranlib messes it up.

In at least Apple's version of ranlib, the output file is updated to havea mod time equal to the max of the timestamps of its components, and thatdata only has seconds precision. On a filesystem with sub-second filetimestamp precision --- say, APFS --- this can result in the finishedstatic library appearing older than its input files, which causes uselessrebuilds and possible outright failures in parallel makes.We've only seen this reported in the field from people using Apple'sranlib with a non-Apple make, because Apple's make doesn't know aboutsub-second timestamps either so it doesn't decide rebuilds are needed.But Apple's ranlib presumably shares code with at least some BSDen,so it's not that unlikely that the same problem could arise elsewhere.To fix, just "touch" the output file after ranlib finishes.We seem to need this in only one place. There are other calls ofranlib in our makefiles, but they are working on intermediate fileswhose timestamps are not actually important, or else on an installedstatic library for which sub-second timestamp precision is unlikelyto matter either. (Also, so far as I can tell, Apple's ranlib doesn'tmess up the file timestamp in the latter usage anyhow.)In passing, change "ranlib" to "$(RANLIB)" in one place that wasbypassing the make macro for no good reason.Per bug #15525 from Jack Kelly (via Alyssa Ross).Back-patch to all supported branches.Discussion:https://postgr.es/m/15525-a30da084f17a1faa@postgresql.org

1 parent6812042 commit826eff5Copy full SHA for 826eff5

File tree

1 file changed

-1

lines changed

src
- Makefile.shlib

1 file changed

-1

lines changed

`‎src/Makefile.shlib`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -287,11 +287,17 @@ all-static-lib: $(stlib)`
`287`	`287`
`288`	`288`	`all-shared-lib: $(shlib)`
`289`	`289`
	`290`	`+# In this rule, "touch $@" works around a problem on some platforms wherein`
	`291`	`+# ranlib updates the library file's mod time with a value calculated to`
	`292`	`+# seconds precision. If the filesystem has sub-second timestamps, this can`
	`293`	`+# cause the library file to appear older than its input files, triggering`
	`294`	`+# parallel-make problems.`
`290`	`295`	`ifndef haslibarule`
`291`	`296`	`$(stlib): $(OBJS) \| $(SHLIB_PREREQS)`
`292`	`297`	`rm -f $@`
`293`	`298`	`$(LINK.static) $@ $^`
`294`	`299`	`$(RANLIB) $@`
	`300`	`+touch $@`
`295`	`301`	`endif #haslibarule`
`296`	`302`
`297`	`303`
`@@ -450,7 +456,7 @@ install-lib-static: $(stlib) installdirs-lib`
`450`	`456`	`$(INSTALL_STLIB) $< '$(DESTDIR)$(libdir)/$(stlib)'`
`451`	`457`	`ifeq ($(PORTNAME), darwin)`
`452`	`458`	`cd '$(DESTDIR)$(libdir)' && \`
`453`		`-ranlib $(stlib)`
	`459`	`+$(RANLIB) $(stlib)`
`454`	`460`	`endif`
`455`	`461`
`456`	`462`	`install-lib-shared: $(shlib) installdirs-lib`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit826eff5

File tree

1 file changed

1 file changed

`‎src/Makefile.shlib`

0 commit comments