NotificationsYou must be signed in to change notification settings
Fork28
Star153

Commit81c766b

committed

Change InitToastSnapshot to a macro.

tqual.h is included in some front-end compiles, and a static inlinebreaks on buildfarm member castoroides. Since the macro is neverreferenced, it should dodge that problem, although this doesn'tseem like the cleanest way of hiding things from front-end compiles.Report and review by Tom Lane; patch by me.

1 parente7caacf commit81c766bCopy full SHA for 81c766b

File tree

2 files changed

-8

lines changed

src
- backend/access/heap
  - tuptoaster.c
- include/utils
  - tqual.h

2 files changed

-8

lines changed

`‎src/backend/access/heap/tuptoaster.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2316,5 +2316,5 @@ init_toast_snapshot(Snapshot toast_snapshot)`
`2316`	`2316`	`if (snapshot==NULL)`
`2317`	`2317`	`elog(ERROR,"no known snapshots");`
`2318`	`2318`
`2319`		`-InitToastSnapshot(toast_snapshot,snapshot->lsn,snapshot->whenTaken);`
	`2319`	`+InitToastSnapshot(*toast_snapshot,snapshot->lsn,snapshot->whenTaken);`
`2320`	`2320`	`}`

`‎src/include/utils/tqual.h‎`

Lines changed: 4 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -104,12 +104,9 @@ extern bool ResolveCminCmaxDuringDecoding(struct HTAB *tuplecid_data,`
`104`	`104`	`* Similarly, some initialization is required for SnapshotToast. We need`
`105`	`105`	`* to set lsn and whenTaken correctly to support snapshot_too_old.`
`106`	`106`	`*/`
`107`		`-staticinlinevoid`
`108`		`-InitToastSnapshot(Snapshotsnapshot,XLogRecPtrlsn,int64whenTaken)`
`109`		`-{`
`110`		`-snapshot->satisfies=HeapTupleSatisfiesToast;`
`111`		`-snapshot->lsn=lsn;`
`112`		`-snapshot->whenTaken=whenTaken;`
`113`		`-}`
	`107`	`+#defineInitToastSnapshot(snapshotdata,l,w) \`
	`108`	`+((snapshotdata).satisfies = HeapTupleSatisfiesDirty, \`
	`109`	`+ (snapshotdata).lsn = (l),\`
	`110`	`+ (snapshotdata).whenTaken = (w))`
`114`	`111`
`115`	`112`	`#endif/* TQUAL_H */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit81c766b

File tree

2 files changed

2 files changed

`‎src/backend/access/heap/tuptoaster.c‎`

`‎src/include/utils/tqual.h‎`

0 commit comments