NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit7e60e67

committed

Tighten test in contrib/bloom/t/001_wal.pl.

Make bloom WAL test compare psql output text, not just result codes;this was evidently the intent all along, but it was mis-coded.In passing, make sure we will notice any failure in setup steps.Alexander Korotkov, reviewed by Michael Paquier and Masahiko SawadaDiscussion:https://postgr.es/m/CAPpHfdtohPdQ9rc5mdWjxq+3VsBNw534KV_5O65dTQrSdVJNgw@mail.gmail.com

1 parentb9941d3 commit7e60e67Copy full SHA for 7e60e67

File tree

1 file changed

-9

lines changed

contrib/bloom/t
- 001_wal.pl

1 file changed

-9

lines changed

`‎contrib/bloom/t/001_wal.pl`

Lines changed: 9 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -32,8 +32,8 @@ sub test_index_replay`
`32`	`32`	`);`
`33`	`33`
`34`	`34`	`# Run test queries and compare their result`
`35`		`-my$master_result =$node_master->psql("postgres",$queries);`
`36`		`-my$standby_result =$node_standby->psql("postgres",$queries);`
	`35`	`+my$master_result =$node_master->safe_psql("postgres",$queries);`
	`36`	`+my$standby_result =$node_standby->safe_psql("postgres",$queries);`
`37`	`37`
`38`	`38`	`is($master_result,$standby_result,"$test_name: query result matches");`
`39`	`39`	`}`
`@@ -54,12 +54,12 @@ sub test_index_replay`
`54`	`54`	`$node_standby->start;`
`55`	`55`
`56`	`56`	`# Create some bloom index on master`
`57`		`-$node_master->psql("postgres","CREATE EXTENSION bloom;");`
`58`		`-$node_master->psql("postgres","CREATE TABLE tst (i int4, t text);");`
`59`		`-$node_master->psql("postgres",`
	`57`	`+$node_master->safe_psql("postgres","CREATE EXTENSION bloom;");`
	`58`	`+$node_master->safe_psql("postgres","CREATE TABLE tst (i int4, t text);");`
	`59`	`+$node_master->safe_psql("postgres",`
`60`	`60`	`"INSERT INTO tst SELECT i%10, substr(md5(i::text), 1, 1) FROM generate_series(1,100000) i;"`
`61`	`61`	`);`
`62`		`-$node_master->psql("postgres",`
	`62`	`+$node_master->safe_psql("postgres",`
`63`	`63`	`"CREATE INDEX bloomidx ON tst USING bloom (i, t) WITH (col1 = 3);");`
`64`	`64`
`65`	`65`	`# Test that queries give same result`
`@@ -68,12 +68,12 @@ sub test_index_replay`
`68`	`68`	`# Run 10 cycles of table modification. Run test queries after each modification.`
`69`	`69`	`formy$i (1 .. 10)`
`70`	`70`	`{`
`71`		`-$node_master->psql("postgres","DELETE FROM tst WHERE i =$i;");`
	`71`	`+$node_master->safe_psql("postgres","DELETE FROM tst WHERE i =$i;");`
`72`	`72`	`test_index_replay("delete$i");`
`73`		`-$node_master->psql("postgres","VACUUM tst;");`
	`73`	`+$node_master->safe_psql("postgres","VACUUM tst;");`
`74`	`74`	`test_index_replay("vacuum$i");`
`75`	`75`	`my ($start,$end) = (100001 + ($i - 1) * 10000, 100000 +$i * 10000);`
`76`		`-$node_master->psql("postgres",`
	`76`	`+$node_master->safe_psql("postgres",`
`77`	`77`	`"INSERT INTO tst SELECT i%10, substr(md5(i::text), 1, 1) FROM generate_series($start,$end) i;"`
`78`	`78`	`);`
`79`	`79`	`test_index_replay("insert$i");`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7e60e67

File tree

1 file changed

1 file changed

`‎contrib/bloom/t/001_wal.pl`

0 commit comments