NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit7e5569f

committed

Fix unportable code in pgbench.

The buildfarm points out that UINT64_FORMAT might not work with sscanf;it's calibrated for our printf implementation, which might not agreewith the platform-supplied sscanf. Fall back to just accepting anunsigned long, which is already more than the documentation promises.Oversight ine6c3ba7; back-patch to v11, as that was.

1 parent76097b4 commit7e5569fCopy full SHA for 7e5569f

File tree

1 file changed

-2

lines changed

src/bin/pgbench
- pgbench.c

1 file changed

-2

lines changed

`‎src/bin/pgbench/pgbench.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -4742,16 +4742,19 @@ set_random_seed(const char *seed)`
`4742`	`4742`	`}`
`4743`	`4743`	`else`
`4744`	`4744`	`{`
`4745`		`-/* parse seed unsigned int value */`
	`4745`	`+/* parse unsigned-int seed value */`
	`4746`	`+unsigned longulseed;`
`4746`	`4747`	`chargarbage;`
`4747`	`4748`
`4748`		`-if (sscanf(seed,UINT64_FORMAT"%c",&iseed,&garbage)!=1)`
	`4749`	`+/* Don't try to use UINT64_FORMAT here; it might not work for sscanf */`
	`4750`	`+if (sscanf(seed,"%lu%c",&ulseed,&garbage)!=1)`
`4749`	`4751`	`{`
`4750`	`4752`	`fprintf(stderr,`
`4751`	`4753`	`"unrecognized random seed option \"%s\": expecting an unsigned integer, \"time\" or \"rand\"\n",`
`4752`	`4754`	`seed);`
`4753`	`4755`	`return false;`
`4754`	`4756`	`}`
	`4757`	`+iseed= (uint64)ulseed;`
`4755`	`4758`	`}`
`4756`	`4759`
`4757`	`4760`	`if (seed!=NULL)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7e5569f

File tree

1 file changed

1 file changed

`‎src/bin/pgbench/pgbench.c`

0 commit comments