Commit7e465d2

committed

remove duplicate code in prepare_rri_fdw_for_insert()

1 parent0963406 commit7e465d2Copy full SHA for 7e465d2

File tree

+13

-14

lines changed

+13

-14

lines changed

Lines changed: 13 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -845,30 +845,29 @@ prepare_rri_fdw_for_insert(EState *estate,`
`845`	`845`	`break;`
`846`	`846`
`847`	`847`	`casePF_FDW_INSERT_POSTGRES:`
	`848`	`+casePF_FDW_INSERT_ANY_FDW:`
`848`	`849`	`{`
`849`	`850`	`ForeignDataWrapper*fdw;`
`850`	`851`	`ForeignServer*fserver;`
`851`	`852`
`852`	`853`	`/* Check if it's PostgreSQL FDW */`
`853`	`854`	`fserver=GetForeignServer(GetForeignTable(partid)->serverid);`
`854`	`855`	`fdw=GetForeignDataWrapper(fserver->fdwid);`
`855`		`-if (strcmp("postgres_fdw",fdw->fdwname)!=0)`
`856`		`-elog(ERROR,"FDWs other than postgres_fdw are restricted");`
`857`		`-}`
`858`		`-break;`
`859`		`-`
`860`		`-casePF_FDW_INSERT_ANY_FDW:`
`861`		`-{`
`862`		`-ForeignDataWrapper*fdw;`
`863`		`-ForeignServer*fserver;`
`864`	`856`
`865`		`-fserver=GetForeignServer(GetForeignTable(partid)->serverid);`
`866`		`-fdw=GetForeignDataWrapper(fserver->fdwid);`
	`857`	`+/* Show message if not postgres_fdw */`
`867`	`858`	`if (strcmp("postgres_fdw",fdw->fdwname)!=0)`
`868`		`-elog(WARNING,"unrestricted FDW mode may lead to \"%s\" crashes",`
`869`		`-fdw->fdwname);`
	`859`	`+switch (pg_pathman_insert_into_fdw)`
	`860`	`+{`
	`861`	`+casePF_FDW_INSERT_POSTGRES:`
	`862`	`+elog(ERROR,`
	`863`	`+"FDWs other than postgres_fdw are restricted");`
	`864`	`+`
	`865`	`+casePF_FDW_INSERT_ANY_FDW:`
	`866`	`+elog(WARNING,`
	`867`	`+"unrestricted FDW mode may lead to crashes");`
	`868`	`+}`
`870`	`869`	`}`
`871`		`-break;/* do nothing */`
	`870`	`+break;`
`872`	`871`
`873`	`872`	`default:`
`874`	`873`	`elog(ERROR,"Mode is not implemented yet");`

Comments

(0)