NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit7ac0069

committed

A small tweak to some comments for PartitionKeyData

It was not really that obvious that there's meant to be exactly 1 itemin the partexprs List for each zero-valued partattrs element. Someincorrect code using these fields was the cause ofCVE-2018-1052, soit's worthwhile to mention how they should be used in the comments.Author: David Rowley <david.rowley@2ndquadrant.com>

1 parent52d8e89 commit7ac0069Copy full SHA for 7ac0069

File tree

1 file changed

-2

lines changed

src/include/utils
- partcache.h

1 file changed

-2

lines changed

`‎src/include/utils/partcache.h`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -26,9 +26,9 @@ typedef struct PartitionKeyData`
`26`	`26`	`charstrategy;/* partitioning strategy */`
`27`	`27`	`int16partnatts;/* number of columns in the partition key */`
`28`	`28`	`AttrNumberpartattrs;/ attribute numbers of columns in the`
`29`		`- * partition key */`
	`29`	`+ * partition keyor 0 if it's an expr*/`
`30`	`30`	`Listpartexprs;/ list of expressions in the partitioning`
`31`		`- * key,or NIL */`
	`31`	`+ * key,one for each zero-valued partattrs */`
`32`	`32`
`33`	`33`	`Oidpartopfamily;/ OIDs of operator families */`
`34`	`34`	`Oidpartopcintype;/ OIDs of opclass declared input data types */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit7ac0069

File tree

1 file changed

1 file changed

`‎src/include/utils/partcache.h`

0 commit comments