NotificationsYou must be signed in to change notification settings
Fork28
Star151

Commit74aa7e0

committed

Fix unique INCLUDE indexes on partitioned tables

We were considering the INCLUDE columns as part of the key, allowingunicity-violating rows to be inserted in different partitions.Concurrent development conflict ineb7ed3f and8224de4.Reported-by: Justin PryzbyDiscussion:https://postgr.es/m/20190109065109.GA4285@telsasoft.com

1 parent20b4ed8 commit74aa7e0Copy full SHA for 74aa7e0

File tree

3 files changed

-1

lines changed

src
- backend/commands
  - indexcmds.c
- test/regress
  - expected
    - indexing.out
  - sql
    - indexing.sql

3 files changed

-1

lines changed

`‎src/backend/commands/indexcmds.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -722,7 +722,7 @@ DefineIndex(Oid relationId,`
`722`	`722`	`errdetail("%s constraints cannot be used when partition keys include expressions.",`
`723`	`723`	`constraint_type)));`
`724`	`724`
`725`		`-for (j=0;j<indexInfo->ii_NumIndexAttrs;j++)`
	`725`	`+for (j=0;j<indexInfo->ii_NumIndexKeyAttrs;j++)`
`726`	`726`	`{`
`727`	`727`	`if (key->partattrs[i]==indexInfo->ii_IndexAttrNumbers[j])`
`728`	`728`	`{`

`‎src/test/regress/expected/indexing.out`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1384,3 +1384,6 @@ insert into covidxpart values (4, 1);`
`1384`	`1384`	`insert into covidxpart values (4, 1);`
`1385`	`1385`	`ERROR: duplicate key value violates unique constraint "covidxpart4_a_b_idx"`
`1386`	`1386`	`DETAIL: Key (a)=(4) already exists.`
	`1387`	`+create unique index on covidxpart (b) include (a); -- should fail`
	`1388`	`+ERROR: insufficient columns in UNIQUE constraint definition`
	`1389`	`+DETAIL: UNIQUE constraint on table "covidxpart" lacks column "a" which is part of the partition key.`

`‎src/test/regress/sql/indexing.sql`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -739,3 +739,4 @@ create unique index on covidxpart4 (a);`
`739`	`739`	`altertable covidxpart attach partition covidxpart4 forvaluesin (4);`
`740`	`740`	`insert into covidxpartvalues (4,1);`
`741`	`741`	`insert into covidxpartvalues (4,1);`
	`742`	`+createunique indexon covidxpart (b) include (a);-- should fail`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit74aa7e0

File tree

3 files changed

3 files changed

`‎src/backend/commands/indexcmds.c`

`‎src/test/regress/expected/indexing.out`

`‎src/test/regress/sql/indexing.sql`

0 commit comments