- Notifications
You must be signed in to change notification settings - Fork28
Commit7393751
committed
Propagate CTE property flags when copying a CTE list into a rule.
rewriteRuleAction() neglected this step, although it was careful topropagate other similar flags such as hasSubLinks or hasRowSecurity.Omitting to transfer hasRecursive is just cosmetic at the moment,but omitting hasModifyingCTE is a live bug, since the executorcertainly looks at that.The proposed test case only fails back to v10, but since the executorexamines hasModifyingCTE in 9.x as well, I suspect that a test casecould be devised that fails in older branches. Given the nearnessof the release deadline, though, I'm not going to spend time lookingfor a better test.Report and patch by Greg Nancarrow, cosmetic changes by meDiscussion:https://postgr.es/m/CAJcOf-fAdj=nDKMsRhQzndm-O13NY4dL6xGcEvdX5Xvbbi0V7g@mail.gmail.com1 parent4353bc8 commit7393751
File tree
3 files changed
+49
-0
lines changed- src
- backend/rewrite
- test/regress
- expected
- sql
3 files changed
+49
-0
lines changedLines changed: 6 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
530 | 530 |
| |
531 | 531 |
| |
532 | 532 |
| |
| 533 | + | |
| 534 | + | |
| 535 | + | |
533 | 536 |
| |
534 | 537 |
| |
535 | 538 |
| |
| |||
551 | 554 |
| |
552 | 555 |
| |
553 | 556 |
| |
| 557 | + | |
| 558 | + | |
| 559 | + | |
554 | 560 |
| |
555 | 561 |
| |
556 | 562 |
| |
|
Lines changed: 27 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1672 | 1672 |
| |
1673 | 1673 |
| |
1674 | 1674 |
| |
| 1675 | + | |
| 1676 | + | |
| 1677 | + | |
| 1678 | + | |
| 1679 | + | |
| 1680 | + | |
| 1681 | + | |
| 1682 | + | |
| 1683 | + | |
| 1684 | + | |
| 1685 | + | |
| 1686 | + | |
| 1687 | + | |
| 1688 | + | |
| 1689 | + | |
| 1690 | + | |
| 1691 | + | |
| 1692 | + | |
| 1693 | + | |
| 1694 | + | |
| 1695 | + | |
| 1696 | + | |
| 1697 | + | |
| 1698 | + | |
| 1699 | + | |
| 1700 | + | |
| 1701 | + | |
1675 | 1702 |
| |
1676 | 1703 |
| |
1677 | 1704 |
| |
|
Lines changed: 16 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
773 | 773 |
| |
774 | 774 |
| |
775 | 775 |
| |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
776 | 792 |
| |
777 | 793 |
| |
778 | 794 |
| |
|
0 commit comments
Comments
(0)