Commit71901ab

committed

Introduce InvalidCommandId.

This allows a 32-bit field to represent an *optional* command IDwithout a separate flag bit.Andres Freund

1 parent9c68834 commit71901abCopy full SHA for 71901ab

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -766,12 +766,12 @@ CommandCounterIncrement(void)`
`766`	`766`	`if (currentCommandIdUsed)`
`767`	`767`	`{`
`768`	`768`	`currentCommandId+=1;`
`769`		`-if (currentCommandId==FirstCommandId)/* check for overflow */`
	`769`	`+if (currentCommandId==InvalidCommandId)`
`770`	`770`	`{`
`771`	`771`	`currentCommandId-=1;`
`772`	`772`	`ereport(ERROR,`
`773`	`773`	`(errcode(ERRCODE_PROGRAM_LIMIT_EXCEEDED),`
`774`		`-errmsg("cannot have more than 2^32-1 commands in a transaction")));`
	`774`	`+errmsg("cannot have more than 2^32-2 commands in a transaction")));`
`775`	`775`	`}`
`776`	`776`	`currentCommandIdUsed= false;`
`777`	`777`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -368,6 +368,7 @@ typedef uint32 MultiXactOffset;`
`368`	`368`	`typedefuint32CommandId;`
`369`	`369`
`370`	`370`	`#defineFirstCommandId((CommandId) 0)`
	`371`	`+#defineInvalidCommandId(~(CommandId)0)`
`371`	`372`
`372`	`373`	`/*`
`373`	`374`	`* Array indexing support`

Comments

(0)