- Notifications
You must be signed in to change notification settings - Fork28
Commit6f7e972
committed
Avoid time-of-day-dependent failure in log rotation test.
Buildfarm members pogona and petalura have shown a failure whenpg_ctl/t/004_logrotate.pl starts just before local midnight.The default rotate-at-midnight behavior occurs just before thePerl script examines current_logfiles, so it figures that therotation it's already requested has occurred ... but in reality,that rotation happens just after it looks, so the expected newlog data goes into a different file than the one it's examining.In HEAD, src/test/kerberos/t/001_auth.pl has acquired similar codethat evidently has a related failure mode. Besides being quite new,few buildfarm critters run that test, so it's unsurprising thatwe've not yet seen a failure there.Fix both cases by setting log_rotation_age = 0 so that no time-basedrotation can occur. Also absorb 004_logrotate.pl's decision toset lc_messages = 'C' into the kerberos test, in hopes that it willwork in non-English prevailing locales.Report:https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pogona&dt=2020-12-24%2022%3A10%3A04Report:https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=petalura&dt=2020-02-01%2022%3A20%3A041 parent0217ad8 commit6f7e972
1 file changed
+2
-0
lines changedLines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
| |||
0 commit comments
Comments
(0)